From 27dfb48a7b2da87f279b5180afcf9e15e2794d33 Mon Sep 17 00:00:00 2001 From: Thorsten Ball Date: Wed, 13 Nov 2024 15:32:19 +0100 Subject: [PATCH] project panel: Fix entries being marked when switching between tabs (#20596) This is a follow-up (or related to) #20412. It fixes entries being marked when navigating between tabs with `cmd-[` and `cmd-]`. Turns out that deep in the bowels of the project panel, we check whether a `shift` modifier was pressed - which is the case with `cmd-[` on a US ANSI layout - and if so mark an entry. I think that's a left-over, because all the other code paths that select/reveal an entry mark it explicitly too. Release Notes: - Fixed entries in project panel being marked when navigating between tabs with keybinding that uses `shift` modifier. --- crates/project_panel/src/project_panel.rs | 6 ------ 1 file changed, 6 deletions(-) diff --git a/crates/project_panel/src/project_panel.rs b/crates/project_panel/src/project_panel.rs index cfced9921d8a7b69158f3830e904913fa881f749..9047823b4cfbe3e005b1559552465ec9bc7a2ff5 100644 --- a/crates/project_panel/src/project_panel.rs +++ b/crates/project_panel/src/project_panel.rs @@ -2145,12 +2145,6 @@ impl ProjectPanel { worktree_id, entry_id, }); - if cx.modifiers().shift { - self.marked_entries.insert(SelectedEntry { - worktree_id, - entry_id, - }); - } } }