markdown: Fix out of range panic in parser (cherry-pick #30510) (#30512)

gcp-cherry-pick-bot[bot] and Bennet Bo Fenner created 8 months ago

Cherry-picked markdown: Fix out of range panic in parser (#30510)

For some reason `pulldown_cmark` treats \````` as a codeblock, meaning
that we could end up with an invalid range generated from
`extract_code_block_content_range` (`3..2`)

Closes #30495

Release Notes:

- agent: Fix an edge case where the editor would crash when model
generated malformed markdown

Co-authored-by: Bennet Bo Fenner <[e-mail]>

Change summary

crates/markdown/src/parser.rs | 7 +++++++
1 file changed, 7 insertions(+)

Detailed changes

crates/markdown/src/parser.rs

@@ -509,6 +509,9 @@ pub(crate) fn extract_code_block_content_range(text: &str) -> Range<usize> {
     if !range.is_empty() && text.ends_with("```") {
         range.end -= 3;
     }
+    if range.start > range.end {
+        range.end = range.start;
+    }
     range
 }
 
@@ -685,6 +688,10 @@ mod tests {
 
         let input = "```python\nprint('hello')\nprint('world')\n```";
         assert_eq!(extract_code_block_content_range(input), 10..40);
+
+        // Malformed input
+        let input = "`````";
+        assert_eq!(extract_code_block_content_range(input), 3..3);
     }
 
     #[test]