From 31e51613bdb952afc299f2c7b7711363dfb5983c Mon Sep 17 00:00:00 2001 From: Bennet Bo Fenner Date: Thu, 16 Apr 2026 21:49:32 +0200 Subject: [PATCH] Remove `test_dockerfile_location_with_compose_context_parent` test (#54119) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Removing it as it seems to constantly fail on CI on Windows. cc @KyleBarton ``` FAIL [ 0.693s] (1511/5475) dev_container devcontainer_manifest::test::test_dockerfile_location_with_compose_context_parent stdout ─── running 1 test test devcontainer_manifest::test::test_dockerfile_location_with_compose_context_parent ... FAILED failures: failures: devcontainer_manifest::test::test_dockerfile_location_with_compose_context_parent test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 62 filtered out; finished in 0.64s stderr ─── thread 'devcontainer_manifest::test::test_dockerfile_location_with_compose_context_parent' (1992) panicked at crates\dev_container\src\devcontainer_manifest.rs:3817:9: assertion `left == right` failed left: None right: Some("C:\\\\path\\to\\local\\project\\.devcontainer/Dockerfile") stack backtrace: 0: std::panicking::panic_handler at /rustc/e408947bfd200af42db322daf0fadfe7e26d3bd1/library\std\src\panicking.rs:689 1: core::panicking::panic_fmt at /rustc/e408947bfd200af42db322daf0fadfe7e26d3bd1/library\core\src\panicking.rs:80 2: core::panicking::assert_failed_inner at /rustc/e408947bfd200af42db322daf0fadfe7e26d3bd1/library\core\src\panicking.rs:439 3: core::panicking::assert_failed >,enum2$ > > at C:\Rust\.rustup\toolchains\1.94.1-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\panicking.rs:394 4: dev_container::devcontainer_manifest::test::test_dockerfile_location_with_compose_context_parent::__test_dockerfile_location_with_compose_context_parent::async_fn$0 at .\src\devcontainer_manifest.rs:3817 5: gpui::executor::impl$4::block_test::async_block$0,enum2$ > at C:\actions-runner\_work\zed\zed\crates\gpui\src\executor.rs:440 6: scheduler::test_scheduler::impl$1::block at C:\actions-runner\_work\zed\zed\crates\scheduler\src\test_scheduler.rs:538 7: gpui::executor::ForegroundExecutor::block_test,enum2$ > at C:\actions-runner\_work\zed\zed\crates\gpui\src\executor.rs:447 8: dev_container::devcontainer_manifest::test::test_dockerfile_location_with_compose_context_parent::closure$0 at .\src\devcontainer_manifest.rs:3796 9: gpui::test::run_test::closure$0 at C:\actions-runner\_work\zed\zed\crates\gpui\src\test.rs:109 10: std::panicking::catch_unwind::do_call > at C:\Rust\.rustup\toolchains\1.94.1-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\panicking.rs:581 11: alloc::vec::spec_from_iter::impl$0::from_iter,alloc::alloc::Global> >,core::iter::adapters::filter_map::FilterMap > at C:\Rust\.rustup\toolchains\1.94.1-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\std\src\panic.rs:359 14: gpui::test::run_test at C:\actions-runner\_work\zed\zed\crates\gpui\src\test.rs:106 15: dev_container::devcontainer_manifest::test::test_dockerfile_location_with_compose_context_parent at .\src\devcontainer_manifest.rs:3796 16: dev_container::devcontainer_manifest::test::test_dockerfile_location_with_compose_context_parent::closure$0 at .\src\devcontainer_manifest.rs:3796 17: core::ops::function::FnOnce::call_once > at C:\Rust\.rustup\toolchains\1.94.1-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\ops\function.rs:250 18: core::ops::function::FnOnce::call_once at /rustc/e408947bfd200af42db322daf0fadfe7e26d3bd1/library\core\src\ops\function.rs:250 note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace. ``` Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - x ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A --- .../src/devcontainer_manifest.rs | 27 ------------------- 1 file changed, 27 deletions(-) diff --git a/crates/dev_container/src/devcontainer_manifest.rs b/crates/dev_container/src/devcontainer_manifest.rs index 9b1783e821c8d15b69ca50a8d8264ca98230eb8e..23f88023f3e31c40cc7391cf6a5e2e161e77fbf4 100644 --- a/crates/dev_container/src/devcontainer_manifest.rs +++ b/crates/dev_container/src/devcontainer_manifest.rs @@ -3793,33 +3793,6 @@ ENV DOCKER_BUILDKIT=1 ); } - #[gpui::test] - async fn test_dockerfile_location_with_compose_context_parent(cx: &mut TestAppContext) { - cx.executor().allow_parking(); - env_logger::try_init().ok(); - - let given_devcontainer_contents = r#" - { - "name": "Test", - "dockerComposeFile": "docker-compose-context-parent.yml", - "service": "app", - "workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}" - } - "#; - let (_, mut devcontainer_manifest) = - init_default_devcontainer_manifest(cx, given_devcontainer_contents) - .await - .unwrap(); - - devcontainer_manifest.parse_nonremote_vars().unwrap(); - - let expected = PathBuf::from(TEST_PROJECT_PATH).join(".devcontainer/Dockerfile"); - assert_eq!( - devcontainer_manifest.dockerfile_location().await, - Some(expected) - ); - } - #[gpui::test] async fn test_spawns_devcontainer_with_docker_compose_and_no_update_uid( cx: &mut TestAppContext,