From 32db140b9545ca7a484fcada1b8968f4f5f31a43 Mon Sep 17 00:00:00 2001 From: Bennet Bo Fenner Date: Tue, 3 Sep 2024 14:33:31 +0200 Subject: [PATCH] assistant: Fix inline assist not restarting transformation after pressing retry (#17301) Release Notes: - Fixed an issue where the inline assist would be dismissed even when instructed to regenerate the transformation after an error --- crates/assistant/src/inline_assistant.rs | 5 ++++- crates/assistant/src/terminal_inline_assistant.rs | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/crates/assistant/src/inline_assistant.rs b/crates/assistant/src/inline_assistant.rs index 871cc5b0250a35a3b0e8f1c19a6b94e1fc9cad20..63c8e45bfdd0d011f09e6982c6c163902ae0ae22 100644 --- a/crates/assistant/src/inline_assistant.rs +++ b/crates/assistant/src/inline_assistant.rs @@ -1794,13 +1794,16 @@ impl PromptEditor { CodegenStatus::Pending => { cx.emit(PromptEditorEvent::DismissRequested); } - CodegenStatus::Done | CodegenStatus::Error(_) => { + CodegenStatus::Done => { if self.edited_since_done { cx.emit(PromptEditorEvent::StartRequested); } else { cx.emit(PromptEditorEvent::ConfirmRequested); } } + CodegenStatus::Error(_) => { + cx.emit(PromptEditorEvent::StartRequested); + } } } diff --git a/crates/assistant/src/terminal_inline_assistant.rs b/crates/assistant/src/terminal_inline_assistant.rs index 426d565cc1fa5f288b96b8540bb0d839be181570..17501959821f1bc69852147a61161be04fb80a38 100644 --- a/crates/assistant/src/terminal_inline_assistant.rs +++ b/crates/assistant/src/terminal_inline_assistant.rs @@ -805,13 +805,16 @@ impl PromptEditor { CodegenStatus::Pending => { cx.emit(PromptEditorEvent::DismissRequested); } - CodegenStatus::Done | CodegenStatus::Error(_) => { + CodegenStatus::Done => { if self.edited_since_done { cx.emit(PromptEditorEvent::StartRequested); } else { cx.emit(PromptEditorEvent::ConfirmRequested); } } + CodegenStatus::Error(_) => { + cx.emit(PromptEditorEvent::StartRequested); + } } }