From 33fc1f4af21c3940d62a9a572269a5504e2e1a06 Mon Sep 17 00:00:00 2001 From: Smit Barmase Date: Fri, 21 Mar 2025 15:13:31 +0530 Subject: [PATCH] languages: Fix JS/TS imports not showing correct suggestions after using period (#27235) Closes #21728 This PR improves autocomplete for imports for all kinds of javascript and typescript files. Adds `.` as `completion_query_characters` which will make it act like word for auto completion context. This allows capturing compete `format.` as query. Before: image After: image Release Notes: - Improved autocomplete suggestions for JavaScript and TypeScript imports. --- crates/languages/src/javascript/config.toml | 2 +- crates/languages/src/tsx/config.toml | 2 +- crates/languages/src/typescript/config.toml | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/crates/languages/src/javascript/config.toml b/crates/languages/src/javascript/config.toml index 182a992d7c95d0ff3806e2f0d1afc83071d9c42b..b5f8e1bc7aab20bee191f9d48caa0874e2802c98 100644 --- a/crates/languages/src/javascript/config.toml +++ b/crates/languages/src/javascript/config.toml @@ -32,5 +32,5 @@ block_comment = ["{/* ", " */}"] opt_into_language_servers = ["emmet-language-server"] [overrides.string] -completion_query_characters = ["-"] +completion_query_characters = ["-", "."] opt_into_language_servers = ["tailwindcss-language-server"] diff --git a/crates/languages/src/tsx/config.toml b/crates/languages/src/tsx/config.toml index b45e6bf9fc642c81ad39b67b4b52bf72482dbd1a..1fbe56b0558db8b177690a7a886b854574cd90ae 100644 --- a/crates/languages/src/tsx/config.toml +++ b/crates/languages/src/tsx/config.toml @@ -30,5 +30,5 @@ block_comment = ["{/* ", " */}"] opt_into_language_servers = ["emmet-language-server"] [overrides.string] -completion_query_characters = ["-"] +completion_query_characters = ["-", "."] opt_into_language_servers = ["tailwindcss-language-server"] diff --git a/crates/languages/src/typescript/config.toml b/crates/languages/src/typescript/config.toml index a34704b8305d4cca147bfa69bfb34419c2298ba5..929deea31f9715bca7d72d8b2fafcce0cc150e48 100644 --- a/crates/languages/src/typescript/config.toml +++ b/crates/languages/src/typescript/config.toml @@ -17,3 +17,6 @@ brackets = [ word_characters = ["#", "$"] prettier_parser_name = "typescript" tab_size = 2 + +[overrides.string] +completion_query_characters = ["."]