Fix a circular reference between Client and UserStore

Conrad Irwin created 2 years ago

Before this change once the UserStore had been created, the Client would
never be dropped.

Change summary

crates/client/src/user.rs | 6 ++++++
1 file changed, 6 insertions(+)

Detailed changes

crates/client/src/user.rs

@@ -146,7 +146,13 @@ impl UserStore {
             }),
             _maintain_current_user: cx.spawn(|this, mut cx| async move {
                 let mut status = client.status();
+                let weak = Arc::downgrade(&client);
+                drop(client);
                 while let Some(status) = status.next().await {
+                    // if the client is dropped, the app is shutting down.
+                    let Some(client) = weak.upgrade() else {
+                        return Ok(());
+                    };
                     match status {
                         Status::Connected { .. } => {
                             if let Some(user_id) = client.user_id() {