Restore `--all-targets` for clippy (#9346)

Marshall Bowers created 2 years ago

This PR restores the `--all-targets` flag when running `cargo clippy`.

Without it, there are areas that Clippy does not check, as evidenced by
the violations that were caught once the flag was re-added.

Release Notes:

- N/A

Change summary

crates/go_to_line/src/go_to_line.rs | 2 +-
crates/outline/src/outline.rs       | 2 +-
tooling/xtask/src/main.rs           | 5 ++++-
3 files changed, 6 insertions(+), 3 deletions(-)

Detailed changes

crates/go_to_line/src/go_to_line.rs

@@ -337,7 +337,7 @@ mod tests {
         workspace: &View<Workspace>,
         cx: &mut VisualTestContext,
     ) -> View<GoToLine> {
-        cx.dispatch_action(Toggle::default());
+        cx.dispatch_action(Toggle);
         workspace.update(cx, |workspace, cx| {
             workspace.active_modal::<GoToLine>(cx).unwrap().clone()
         })

crates/outline/src/outline.rs

@@ -447,7 +447,7 @@ mod tests {
         workspace: &View<Workspace>,
         cx: &mut VisualTestContext,
     ) -> View<Picker<OutlineViewDelegate>> {
-        cx.dispatch_action(Toggle::default());
+        cx.dispatch_action(Toggle);
         workspace.update(cx, |workspace, cx| {
             workspace
                 .active_modal::<OutlineView>(cx)

tooling/xtask/src/main.rs

@@ -47,7 +47,10 @@ fn run_clippy(args: ClippyArgs) -> Result<()> {
         clippy_command.arg("--workspace");
     }
 
-    clippy_command.arg("--release").arg("--all-features");
+    clippy_command
+        .arg("--release")
+        .arg("--all-targets")
+        .arg("--all-features");
 
     if args.fix {
         clippy_command.arg("--fix");