Only compile visual tests in CI, don't run them

Richard Feldman created 4 weeks ago

The baseline images aren't committed yet, so running them fails.
Change the CI step from cargo run to cargo build so we at least
verify the visual test runner compiles on every PR.

Change summary

.github/workflows/release.yml                  | 4 ++--
.github/workflows/run_tests.yml                | 4 ++--
tooling/xtask/src/tasks/workflows/run_tests.rs | 2 +-
tooling/xtask/src/tasks/workflows/steps.rs     | 4 ++--
4 files changed, 7 insertions(+), 7 deletions(-)

Detailed changes

.github/workflows/release.yml

@@ -43,8 +43,8 @@ jobs:
         SCCACHE_BUCKET: sccache-zed
     - name: steps::cargo_nextest
       run: cargo nextest run --workspace --no-fail-fast --no-tests=warn
-    - name: steps::cargo_run_visual_tests
-      run: cargo run -p zed --bin zed_visual_test_runner --features visual-tests
+    - name: steps::cargo_build_visual_tests
+      run: cargo build -p zed --bin zed_visual_test_runner --features visual-tests
     - name: steps::show_sccache_stats
       run: sccache --show-stats || true
     - name: steps::cleanup_cargo_config

.github/workflows/run_tests.yml

@@ -440,8 +440,8 @@ jobs:
         SCCACHE_BUCKET: sccache-zed
     - name: steps::cargo_nextest
       run: cargo nextest run --workspace --no-fail-fast --no-tests=warn${{ needs.orchestrate.outputs.changed_packages && format(' -E "{0}"', needs.orchestrate.outputs.changed_packages) || '' }}
-    - name: steps::cargo_run_visual_tests
-      run: cargo run -p zed --bin zed_visual_test_runner --features visual-tests
+    - name: steps::cargo_build_visual_tests
+      run: cargo build -p zed --bin zed_visual_test_runner --features visual-tests
     - name: steps::show_sccache_stats
       run: sccache --show-stats || true
     - name: steps::cleanup_cargo_config

tooling/xtask/src/tasks/workflows/run_tests.rs

@@ -597,7 +597,7 @@ fn run_platform_tests_impl(platform: Platform, filter_packages: bool) -> NamedJo
                 job.add_step(steps::cargo_nextest(platform))
             })
             .when(platform == Platform::Mac, |job| {
-                job.add_step(steps::cargo_run_visual_tests())
+                job.add_step(steps::cargo_build_visual_tests())
             })
             .add_step(steps::show_sccache_stats(platform))
             .add_step(steps::cleanup_cargo_config(platform)),

tooling/xtask/src/tasks/workflows/steps.rs

@@ -254,8 +254,8 @@ pub fn setup_sccache(platform: Platform) -> Step<Run> {
         .add_env(("SCCACHE_BUCKET", SCCACHE_R2_BUCKET))
 }
 
-pub fn cargo_run_visual_tests() -> Step<Run> {
-    named::bash("cargo run -p zed --bin zed_visual_test_runner --features visual-tests")
+pub fn cargo_build_visual_tests() -> Step<Run> {
+    named::bash("cargo build -p zed --bin zed_visual_test_runner --features visual-tests")
 }
 
 pub fn show_sccache_stats(platform: Platform) -> Step<Run> {