Address review feedback.

Piotr Osiewicz created 2 years ago

Rename selected_rows to background_highlight_row_ranges.
Do not return any ranges if there are more than 50k results

Change summary

crates/editor/src/editor.rs  | 6 ++++--
crates/editor/src/element.rs | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)

Detailed changes

crates/editor/src/editor.rs

@@ -7549,7 +7549,7 @@ impl Editor {
         results
     }
 
-    pub fn selected_rows<T: 'static>(
+    pub fn background_highlight_row_ranges<T: 'static>(
         &self,
         search_range: Range<Anchor>,
         display_snapshot: &DisplaySnapshot,
@@ -7616,7 +7616,9 @@ impl Editor {
         }
         // We might still have a hunk that was not rendered (if there was a search hit on the last line)
         push_region(start_row, end_row);
-
+        if results.len() > count {
+            return vec![];
+        }
         results
     }
 

crates/editor/src/element.rs

@@ -1133,7 +1133,7 @@ impl EditorElement {
                     })
                 };
                 let background_ranges = editor
-                    .selected_rows::<crate::items::BufferSearchHighlights>(
+                    .background_highlight_row_ranges::<crate::items::BufferSearchHighlights>(
                         start_anchor..end_anchor,
                         &layout.position_map.snapshot,
                         50000,