From 38ede4bae333572467c1ac37b3ff9a7955d5d89c Mon Sep 17 00:00:00 2001 From: Cole Miller Date: Wed, 30 Apr 2025 16:54:53 -0400 Subject: [PATCH] Fix parsing of author name in git show output (#29704) Closes #ISSUE Release Notes: - Fixed a bug causing incorrect formatting of git commit tooltips --- crates/git/src/repository.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/git/src/repository.rs b/crates/git/src/repository.rs index fc293d8a4f143eced926b00bb1c36f63fcdfaf29..14fade10741ed86163abcf926448b7e03d5c377c 100644 --- a/crates/git/src/repository.rs +++ b/crates/git/src/repository.rs @@ -411,13 +411,13 @@ impl GitRepository for RealGitRepository { "--no-optional-locks", "show", "--no-patch", - "--format=%H%x00%B%x00%at%x00%ae%x00%an", + "--format=%H%x00%B%x00%at%x00%ae%x00%an%x00", &commit, ]) .output()?; let output = std::str::from_utf8(&output.stdout)?; let fields = output.split('\0').collect::>(); - if fields.len() != 5 { + if fields.len() != 6 { bail!("unexpected git-show output for {commit:?}: {output:?}") } let sha = fields[0].to_string().into();