From 3948e36e40ca2f74270846b40b29a0b6e9aea13e Mon Sep 17 00:00:00 2001 From: Conrad Irwin Date: Sun, 2 Nov 2025 22:33:11 -0700 Subject: [PATCH] No need for outputs anymore --- .github/workflows/release.yml | 16 --------- .github/workflows/release_nightly.yml | 16 --------- .github/workflows/run_bundling.yml | 16 --------- .../xtask/src/tasks/workflows/run_bundling.rs | 34 ++----------------- 4 files changed, 3 insertions(+), 79 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 04d9e4d456d417cd18f8954360324d17e13a5370..7fd5bba43dae4d2e9194daa931a626b20147977f 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -213,9 +213,6 @@ jobs: name: zed-remote-server-linux-aarch64.gz path: target/zed-remote-server-*.gz if-no-files-found: error - outputs: - zed: zed-linux-aarch64.tar.gz - remote-server: zed-remote-server-linux-aarch64.gz timeout-minutes: 60 bundle_linux_x86_64: needs: @@ -256,9 +253,6 @@ jobs: name: zed-remote-server-linux-x86_64.gz path: target/zed-remote-server-*.gz if-no-files-found: error - outputs: - zed: zed-linux-x86_64.tar.gz - remote-server: zed-remote-server-linux-x86_64.gz timeout-minutes: 60 bundle_mac_aarch64: needs: @@ -305,9 +299,6 @@ jobs: name: zed-remote-server-macos-aarch64.gz path: target/zed-remote-server-macos-aarch64.gz if-no-files-found: error - outputs: - zed: Zed-aarch64.dmg - remote-server: zed-remote-server-macos-aarch64.gz timeout-minutes: 60 bundle_mac_x86_64: needs: @@ -354,9 +345,6 @@ jobs: name: zed-remote-server-macos-x86_64.gz path: target/zed-remote-server-macos-x86_64.gz if-no-files-found: error - outputs: - zed: Zed-x86_64.dmg - remote-server: zed-remote-server-macos-x86_64.gz timeout-minutes: 60 bundle_windows_aarch64: needs: @@ -395,8 +383,6 @@ jobs: name: Zed-aarch64.exe path: ${{ env.SETUP_PATH }} if-no-files-found: error - outputs: - zed: Zed-aarch64.exe timeout-minutes: 60 bundle_windows_x86_64: needs: @@ -435,8 +421,6 @@ jobs: name: Zed-x86_64.exe path: ${{ env.SETUP_PATH }} if-no-files-found: error - outputs: - zed: Zed-x86_64.exe timeout-minutes: 60 upload_release_assets: needs: diff --git a/.github/workflows/release_nightly.yml b/.github/workflows/release_nightly.yml index 9fb255cd0760d0caaf68704ec6065a7881f7a7df..bebc17dbbc08802047783171ddbd8e6356e30343 100644 --- a/.github/workflows/release_nightly.yml +++ b/.github/workflows/release_nightly.yml @@ -108,9 +108,6 @@ jobs: name: zed-remote-server-linux-aarch64.gz path: target/zed-remote-server-*.gz if-no-files-found: error - outputs: - zed: zed-linux-aarch64.tar.gz - remote-server: zed-remote-server-linux-aarch64.gz timeout-minutes: 60 bundle_linux_x86_64: needs: @@ -158,9 +155,6 @@ jobs: name: zed-remote-server-linux-x86_64.gz path: target/zed-remote-server-*.gz if-no-files-found: error - outputs: - zed: zed-linux-x86_64.tar.gz - remote-server: zed-remote-server-linux-x86_64.gz timeout-minutes: 60 bundle_mac_aarch64: needs: @@ -214,9 +208,6 @@ jobs: name: zed-remote-server-macos-aarch64.gz path: target/zed-remote-server-macos-aarch64.gz if-no-files-found: error - outputs: - zed: Zed-aarch64.dmg - remote-server: zed-remote-server-macos-aarch64.gz timeout-minutes: 60 bundle_mac_x86_64: needs: @@ -270,9 +261,6 @@ jobs: name: zed-remote-server-macos-x86_64.gz path: target/zed-remote-server-macos-x86_64.gz if-no-files-found: error - outputs: - zed: Zed-x86_64.dmg - remote-server: zed-remote-server-macos-x86_64.gz timeout-minutes: 60 bundle_windows_aarch64: needs: @@ -319,8 +307,6 @@ jobs: name: Zed-aarch64.exe path: ${{ env.SETUP_PATH }} if-no-files-found: error - outputs: - zed: Zed-aarch64.exe timeout-minutes: 60 bundle_windows_x86_64: needs: @@ -367,8 +353,6 @@ jobs: name: Zed-x86_64.exe path: ${{ env.SETUP_PATH }} if-no-files-found: error - outputs: - zed: Zed-x86_64.exe timeout-minutes: 60 build_nix_linux_x86_64: needs: diff --git a/.github/workflows/run_bundling.yml b/.github/workflows/run_bundling.yml index 2dc318b84f7c24fa778c31e8665d33cc2f6bd146..25095d0b0d7b590137f59f35d68c0c1cf112599d 100644 --- a/.github/workflows/run_bundling.yml +++ b/.github/workflows/run_bundling.yml @@ -49,9 +49,6 @@ jobs: name: zed-remote-server-linux-aarch64.gz path: target/zed-remote-server-*.gz if-no-files-found: error - outputs: - zed: zed-linux-aarch64.tar.gz - remote-server: zed-remote-server-linux-aarch64.gz timeout-minutes: 60 bundle_linux_x86_64: if: |- @@ -92,9 +89,6 @@ jobs: name: zed-remote-server-linux-x86_64.gz path: target/zed-remote-server-*.gz if-no-files-found: error - outputs: - zed: zed-linux-x86_64.tar.gz - remote-server: zed-remote-server-linux-x86_64.gz timeout-minutes: 60 bundle_mac_aarch64: if: |- @@ -141,9 +135,6 @@ jobs: name: zed-remote-server-macos-aarch64.gz path: target/zed-remote-server-macos-aarch64.gz if-no-files-found: error - outputs: - zed: Zed-aarch64.dmg - remote-server: zed-remote-server-macos-aarch64.gz timeout-minutes: 60 bundle_mac_x86_64: if: |- @@ -190,9 +181,6 @@ jobs: name: zed-remote-server-macos-x86_64.gz path: target/zed-remote-server-macos-x86_64.gz if-no-files-found: error - outputs: - zed: Zed-x86_64.dmg - remote-server: zed-remote-server-macos-x86_64.gz timeout-minutes: 60 bundle_windows_aarch64: if: |- @@ -231,8 +219,6 @@ jobs: name: Zed-aarch64.exe path: ${{ env.SETUP_PATH }} if-no-files-found: error - outputs: - zed: Zed-aarch64.exe timeout-minutes: 60 bundle_windows_x86_64: if: |- @@ -271,8 +257,6 @@ jobs: name: Zed-x86_64.exe path: ${{ env.SETUP_PATH }} if-no-files-found: error - outputs: - zed: Zed-x86_64.exe timeout-minutes: 60 concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.ref }} diff --git a/tooling/xtask/src/tasks/workflows/run_bundling.rs b/tooling/xtask/src/tasks/workflows/run_bundling.rs index 055faf78dbda3706ffe16983d2843d4eeb5d9a90..b2bea3867bebf0203d9499867cfe6fc3586b25bd 100644 --- a/tooling/xtask/src/tasks/workflows/run_bundling.rs +++ b/tooling/xtask/src/tasks/workflows/run_bundling.rs @@ -7,7 +7,6 @@ use crate::tasks::workflows::{ use super::{runners, steps}; use gh_workflow::*; -use indexmap::IndexMap; pub fn run_bundling() -> Workflow { let bundle = ReleaseBundleJobs { @@ -85,18 +84,7 @@ pub(crate) fn bundle_mac( .add_step(steps::upload_artifact( &remote_server_artifact_name, &format!("target/zed-remote-server-macos-{arch}.gz"), - )) - .outputs( - [ - ("zed".to_string(), artifact_name.to_string()), - ( - "remote-server".to_string(), - remote_server_artifact_name.to_string(), - ), - ] - .into_iter() - .collect::>(), - ), + )), } } @@ -133,18 +121,7 @@ pub(crate) fn bundle_linux( .add_step(steps::upload_artifact( &remote_server_artifact_name, "target/zed-remote-server-*.gz", - )) - .outputs( - [ - ("zed".to_string(), artifact_name.to_string()), - ( - "remote-server".to_string(), - remote_server_artifact_name.to_string(), - ), - ] - .into_iter() - .collect::>(), - ), + )), } } @@ -179,12 +156,7 @@ pub(crate) fn bundle_windows( .add_step(steps::upload_artifact( &artifact_name, "${{ env.SETUP_PATH }}", - )) - .outputs( - [("zed".to_string(), artifact_name.to_string())] - .into_iter() - .collect::>(), - ), + )), } }