From 39dd133b1c80493f659e7f8a918c452c6279ce96 Mon Sep 17 00:00:00 2001 From: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Date: Thu, 1 May 2025 15:09:14 -0300 Subject: [PATCH] agent: Remove unused `agent: chat mode` command palette action (#29741) We weren't using this one anymore. We used to use it for the switch that toggled tools on, which doesn't exist anymore. Release Notes: - N/A --------- Co-authored-by: Joseph T. Lyons --- assets/keymaps/default-linux.json | 1 - assets/keymaps/default-macos.json | 1 - crates/agent/src/assistant.rs | 1 - crates/agent/src/message_editor.rs | 7 +------ 4 files changed, 1 insertion(+), 9 deletions(-) diff --git a/assets/keymaps/default-linux.json b/assets/keymaps/default-linux.json index d3e02e59528d9fe5d696da9902e1e6ae5e945dbc..91074a5f1c3acc160b749721ace2ba45bdd3909b 100644 --- a/assets/keymaps/default-linux.json +++ b/assets/keymaps/default-linux.json @@ -248,7 +248,6 @@ "ctrl-shift-o": "agent::ToggleNavigationMenu", "ctrl-shift-i": "agent::ToggleOptionsMenu", "shift-escape": "agent::ExpandMessageEditor", - "ctrl-e": "agent::ChatMode", "ctrl-alt-e": "agent::RemoveAllContext" } }, diff --git a/assets/keymaps/default-macos.json b/assets/keymaps/default-macos.json index b252617b4726c7890c9fde42026d47236cd0b50e..ef0255a29491461905069dadbded3654a0fed1ca 100644 --- a/assets/keymaps/default-macos.json +++ b/assets/keymaps/default-macos.json @@ -293,7 +293,6 @@ "cmd-shift-o": "agent::ToggleNavigationMenu", "cmd-shift-i": "agent::ToggleOptionsMenu", "shift-escape": "agent::ExpandMessageEditor", - "cmd-e": "agent::ChatMode", "cmd-alt-e": "agent::RemoveAllContext" } }, diff --git a/crates/agent/src/assistant.rs b/crates/agent/src/assistant.rs index 7c2050159500a3c44a012a50bcd63ccb348c0b79..3fe77a27daf62b7f75b655518f59c5ca3329b78c 100644 --- a/crates/agent/src/assistant.rs +++ b/crates/agent/src/assistant.rs @@ -62,7 +62,6 @@ actions!( AddContextServer, RemoveSelectedThread, Chat, - ChatMode, CycleNextInlineAssist, CyclePreviousInlineAssist, FocusUp, diff --git a/crates/agent/src/message_editor.rs b/crates/agent/src/message_editor.rs index 3df2ecefc75265ad06aaac30ac9910bd7dbac0fb..924ed797660463809aa8fc9d9b066a97d3384afb 100644 --- a/crates/agent/src/message_editor.rs +++ b/crates/agent/src/message_editor.rs @@ -42,7 +42,7 @@ use crate::profile_selector::ProfileSelector; use crate::thread::{Thread, TokenUsageRatio}; use crate::thread_store::ThreadStore; use crate::{ - AgentDiff, Chat, ChatMode, ExpandMessageEditor, NewThread, OpenAgentDiff, RemoveAllContext, + AgentDiff, Chat, ExpandMessageEditor, NewThread, OpenAgentDiff, RemoveAllContext, ToggleContextPicker, ToggleProfileSelector, }; @@ -206,10 +206,6 @@ impl MessageEditor { &self.context_store } - fn toggle_chat_mode(&mut self, _: &ChatMode, _window: &mut Window, cx: &mut Context) { - cx.notify(); - } - pub fn expand_message_editor( &mut self, _: &ExpandMessageEditor, @@ -499,7 +495,6 @@ impl MessageEditor { .on_action(cx.listener(Self::toggle_context_picker)) .on_action(cx.listener(Self::remove_all_context)) .on_action(cx.listener(Self::move_up)) - .on_action(cx.listener(Self::toggle_chat_mode)) .on_action(cx.listener(Self::expand_message_editor)) .capture_action(cx.listener(Self::paste)) .gap_2()