From 3a6a29f1173e3cc1059d2220985a53581864388c Mon Sep 17 00:00:00 2001 From: Thorsten Ball Date: Wed, 11 Sep 2024 16:13:17 -0400 Subject: [PATCH] vim: Fix inline completions showing up in normal mode (#17727) Booleans are hard. Release Notes: - Fixed inline completions showing up in Vim normal mode. --- crates/editor/src/editor.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/crates/editor/src/editor.rs b/crates/editor/src/editor.rs index f750abd95c76df625a04690b79567bd80ca0f961..e50bf67ab01a289acbf86ffe9db8025cfaa9f4a6 100644 --- a/crates/editor/src/editor.rs +++ b/crates/editor/src/editor.rs @@ -4975,9 +4975,10 @@ impl Editor { let cursor = self.selections.newest_anchor().head(); let (buffer, cursor_buffer_position) = self.buffer.read(cx).text_anchor_for_position(cursor, cx)?; + if !user_requested - && self.enable_inline_completions - && !self.should_show_inline_completions(&buffer, cursor_buffer_position, cx) + && (!self.enable_inline_completions + || !self.should_show_inline_completions(&buffer, cursor_buffer_position, cx)) { self.discard_inline_completion(false, cx); return None;