From 3c4903c6bf631792af30ba5f393e0dbb6fc107d3 Mon Sep 17 00:00:00 2001 From: GiM Date: Fri, 21 Feb 2025 16:23:58 +0100 Subject: [PATCH] Pass "menu" key presses in windows down as a `Keystroke` (#25000) This is second part needed for #17819. There is already binding in default bindings: `"menu": "editor::OpenContextMenu",` (but won't work on windows without this change) Release Notes: - Handle "menu" key in windows --- crates/gpui/src/platform/windows/events.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crates/gpui/src/platform/windows/events.rs b/crates/gpui/src/platform/windows/events.rs index 20a4bae3a6aa460b151ce631f64e6fc97acb19f3..c34ca6e7e45e261fd480312705f36f3f6c6ec667 100644 --- a/crates/gpui/src/platform/windows/events.rs +++ b/crates/gpui/src/platform/windows/events.rs @@ -1249,6 +1249,7 @@ fn parse_syskeydown_msg_keystroke(wparam: WPARAM) -> Option { VK_ESCAPE => "escape", VK_INSERT => "insert", VK_DELETE => "delete", + VK_APPS => "menu", _ => { let basic_key = basic_vkcode_to_string(vk_code, modifiers); if basic_key.is_some() { @@ -1303,6 +1304,7 @@ fn parse_keydown_msg_keystroke(wparam: WPARAM) -> Option { VK_ESCAPE => "escape", VK_INSERT => "insert", VK_DELETE => "delete", + VK_APPS => "menu", _ => { if is_modifier(VIRTUAL_KEY(vk_code)) { return Some(KeystrokeOrModifier::Modifier(modifiers));