Correct more app event inconsistencies (#21129)

Joseph T. Lyons created 1 year ago

- Unify welcome page event type string structure
- Differentiate between metric telemetry event and diagnostic telemetry
event

Release Notes:

- N/A

Change summary

crates/collab/src/api/events.rs | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

Detailed changes

crates/collab/src/api/events.rs

@@ -1471,22 +1471,22 @@ fn for_snowflake(
                     "open ssh project" => "SSH Project Opened".to_string(),
 
                     // Welcome Page
-                    "welcome page: change keymap" => "Keymap Changed".to_string(),
+                    "welcome page: change keymap" => "Welcome Keymap Changed".to_string(),
                     "welcome page: change theme" => "Welcome Theme Changed".to_string(),
                     "welcome page: close" => "Welcome Page Closed".to_string(),
-                    "welcome page: edit settings" => "Settings Edited".to_string(),
-                    "welcome page: install cli" => "CLI Installed".to_string(),
+                    "welcome page: edit settings" => "Welcome Settings Edited".to_string(),
+                    "welcome page: install cli" => "Welcome CLI Installed".to_string(),
                     "welcome page: open" => "Welcome Page Opened".to_string(),
-                    "welcome page: open extensions" => "Extensions Page Opened".to_string(),
+                    "welcome page: open extensions" => "Welcome Extensions Page Opened".to_string(),
                     "welcome page: sign in to copilot" => "Welcome Copilot Signed In".to_string(),
                     "welcome page: toggle diagnostic telemetry" => {
-                        "Welcome Telemetry Toggled".to_string()
+                        "Welcome Diagnostic Telemetry Toggled".to_string()
                     }
                     "welcome page: toggle metric telemetry" => {
-                        "Welcome Telemetry Toggled".to_string()
+                        "Welcome Metric Telemetry Toggled".to_string()
                     }
                     "welcome page: toggle vim" => "Welcome Vim Mode Toggled".to_string(),
-                    "welcome page: view docs" => "Documentation Viewed".to_string(),
+                    "welcome page: view docs" => "Welcome Documentation Viewed".to_string(),
 
                     // Extensions
                     "extensions page: open" => "Extensions Page Opened".to_string(),