Enable `clippy::unnecessary_find_map` (#8740)

Marshall Bowers created 2 years ago

This PR enables the
[`clippy::unnecessary_find_map`](https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_find_map)
rule and fixes the outstanding violations.

Release Notes:

- N/A

Change summary

crates/collab_ui/src/chat_panel.rs | 8 ++------
tooling/xtask/src/main.rs          | 1 -
2 files changed, 2 insertions(+), 7 deletions(-)

Detailed changes

crates/collab_ui/src/chat_panel.rs

@@ -839,12 +839,8 @@ impl Render for ChatPanel {
                 let reply_message = self
                     .active_chat()
                     .and_then(|active_chat| {
-                        active_chat.read(cx).messages().iter().find_map(|m| {
-                            if m.id == ChannelMessageId::Saved(reply_to_message_id) {
-                                Some(m)
-                            } else {
-                                None
-                            }
+                        active_chat.read(cx).messages().iter().find(|message| {
+                            message.id == ChannelMessageId::Saved(reply_to_message_id)
                         })
                     })
                     .cloned();

tooling/xtask/src/main.rs

@@ -123,7 +123,6 @@ fn run_clippy(args: ClippyArgs) -> Result<()> {
         "clippy::suspicious_to_owned",
         "clippy::type_complexity",
         "clippy::unit_arg",
-        "clippy::unnecessary_find_map",
         "clippy::unnecessary_operation",
         "clippy::unnecessary_to_owned",
         "clippy::unnecessary_unwrap",