From 3f6960bd3436742ec97a4e2ed5b7d18f1c555f2c Mon Sep 17 00:00:00 2001
From: Antonio Scandurra <me@as-cii.com>
Date: Wed, 26 Jan 2022 16:03:06 +0100
Subject: [PATCH] Position underlines at a distance proportional to the line
 descent

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
---
 crates/gpui/src/text_layout.rs | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/crates/gpui/src/text_layout.rs b/crates/gpui/src/text_layout.rs
index 30a0e99502a76a772a9ce7c63de4990fc248edd2..6e371437bfdba44993d6a06d20ad85881ad6dd0a 100644
--- a/crates/gpui/src/text_layout.rs
+++ b/crates/gpui/src/text_layout.rs
@@ -272,7 +272,13 @@ impl Line {
                             }
                         }
                         if let Some(run_underline) = run_underline {
-                            underline.get_or_insert((glyph_origin, *run_underline));
+                            underline.get_or_insert((
+                                vec2f(
+                                    glyph_origin.x(),
+                                    origin.y() + baseline_offset.y() + 0.618 * self.layout.descent,
+                                ),
+                                *run_underline,
+                            ));
                         }
 
                         run_end += *run_len as usize;