diff --git a/crates/terminal/src/connected_el.rs b/crates/terminal/src/connected_el.rs index e0117192fd055525d168e70c1dc3db8f4380f596..20a97b53d3623be6295993d99ff9534eba3c2d9c 100644 --- a/crates/terminal/src/connected_el.rs +++ b/crates/terminal/src/connected_el.rs @@ -439,9 +439,9 @@ impl TerminalEl { let mut region = MouseRegion::new(view_id, None, visible_bounds); - //Terminal Emulator controlled behavior: + // Terminal Emulator controlled behavior: region = region - //Start selections + // Start selections .on_down( MouseButton::Left, TerminalEl::generic_button_handler( @@ -452,7 +452,7 @@ impl TerminalEl { }, ), ) - //Update drag selections + // Update drag selections .on_drag(MouseButton::Left, move |_prev, event, cx| { if cx.is_parent_view_focused() { if let Some(conn_handle) = connection.upgrade(cx.app) { @@ -463,7 +463,7 @@ impl TerminalEl { } } }) - //Copy on up behavior + // Copy on up behavior .on_up( MouseButton::Left, TerminalEl::generic_button_handler( @@ -474,7 +474,7 @@ impl TerminalEl { }, ), ) - //Handle click based selections + // Handle click based selections .on_click( MouseButton::Left, TerminalEl::generic_button_handler( @@ -485,14 +485,14 @@ impl TerminalEl { }, ), ) - //Context menu + // Context menu .on_click( MouseButton::Right, move |e @ MouseButtonEvent { position, .. }, cx| { let mouse_mode = if let Some(conn_handle) = connection.upgrade(cx.app) { conn_handle.update(cx.app, |terminal, _cx| terminal.mouse_mode(e.shift)) } else { - //If we can't get the model handle, probably can't deploy the context menu + // If we can't get the model handle, probably can't deploy the context menu true }; if !mouse_mode { @@ -501,7 +501,8 @@ impl TerminalEl { }, ); - //All mouse modes need the extra click handlers + // Mouse mode handlers: + // All mouse modes need the extra click handlers if mode.intersects(TermMode::MOUSE_MODE) { region = region .on_down( @@ -548,7 +549,7 @@ impl TerminalEl { //Mouse move manages both dragging and motion events if mode.intersects(TermMode::MOUSE_DRAG | TermMode::MOUSE_MOTION) { region = region - //This does not fire on right-mouse-down-move events wild. + //TODO: This does not fire on right-mouse-down-move events. .on_move(move |event, cx| { if cx.is_parent_view_focused() { if let Some(conn_handle) = connection.upgrade(cx.app) { @@ -561,8 +562,6 @@ impl TerminalEl { }) } - //TODO: Mouse drag isn't correct - //TODO: Nor is mouse motion. Move events aren't happening?? cx.scene.push_mouse_region(region); }