diff --git a/.github/workflows/compare_perf.yml b/.github/workflows/compare_perf.yml index f7a917d452d6d3be7a8d9ad41c614b41cbb1a12a..6f458d325d5e8441aee04a98fd1665401e0ece9d 100644 --- a/.github/workflows/compare_perf.yml +++ b/.github/workflows/compare_perf.yml @@ -24,12 +24,12 @@ jobs: run: echo ${{ inputs.base }} ${{ inputs.head }} shell: bash -euxo pipefail {0} - name: git checkout ${{ inputs.base }} - run: git checkout {ref_name} + run: git checkout ${{ inputs.base }} - name: compare_perf::run_perf::cargo_perf_test run: cargo perf-test -p gpui -- --json=${{ inputs.base }} shell: bash -euxo pipefail {0} - name: git checkout ${{ inputs.head }} - run: git checkout {ref_name} + run: git checkout ${{ inputs.head }} - name: compare_perf::run_perf::cargo_perf_test run: cargo perf-test -p gpui -- --json=${{ inputs.head }} shell: bash -euxo pipefail {0} diff --git a/tooling/xtask/src/tasks/workflows/compare_perf.rs b/tooling/xtask/src/tasks/workflows/compare_perf.rs index b5968f88dbd9bcc6ca3055bc6302842a8a405a05..8cd4ddf5f5691c447d5953f48889277a06c8d0a5 100644 --- a/tooling/xtask/src/tasks/workflows/compare_perf.rs +++ b/tooling/xtask/src/tasks/workflows/compare_perf.rs @@ -25,11 +25,12 @@ pub fn run_perf(base: &Input, head: &Input) -> NamedJob { } fn cargo_perf_test(ref_name: String) -> Step { + // TODO: vim not gpui, and ideally allow args named::bash(&format!("cargo perf-test -p gpui -- --json={ref_name}")) } fn git_checkout(ref_name: String) -> Step { - Step::new(&format!("git checkout {ref_name}")).run("git checkout {ref_name}") + Step::new(&format!("git checkout {ref_name}")).run(&format!("git checkout {ref_name}")) } fn compare_runs(head: String, base: String) -> Step {