Remove redundant install Rust steps
Kirill Bulatov
and
Piotr
created 2 years ago
Those were not installing Rust but configuring it via rustup, and
those configurations were done on `stable` toolchain which is not what we use (see rust-toolchain.toml)
co-authored-by: Piotr <piotr@zed.dev>
Change summary
.github/actions/check_style/action.yml | 6 --
.github/actions/run_tests/action.yml | 41 +++++++++----------
.github/workflows/ci.yml | 8 ---
.github/workflows/randomized_tests.yml | 59 ++++++++++++---------------
.github/workflows/release_nightly.yml | 8 ---
crates/editor/src/editor_tests.rs | 1
rust-toolchain.toml | 1
7 files changed, 47 insertions(+), 77 deletions(-)
Detailed changes
@@ -4,12 +4,6 @@ description: "Checks code formatting use cargo fmt"
runs:
using: "composite"
steps:
- - name: Install Rust
- shell: bash -euxo pipefail {0}
- run: |
- rustup set profile minimal
- rustup update stable
-
- name: cargo fmt
shell: bash -euxo pipefail {0}
run: cargo fmt --all -- --check
@@ -2,29 +2,26 @@ name: "Run tests"
description: "Runs the tests"
runs:
- using: "composite"
- steps:
- - name: Install Rust
- shell: bash -euxo pipefail {0}
- run: |
- rustup set profile minimal
- rustup update stable
- rustup target add wasm32-wasi
- cargo install cargo-nextest
+ using: "composite"
+ steps:
+ - name: Install Rust
+ shell: bash -euxo pipefail {0}
+ run: |
+ cargo install cargo-nextest
- - name: Install Node
- uses: actions/setup-node@v3
- with:
- node-version: "18"
+ - name: Install Node
+ uses: actions/setup-node@v3
+ with:
+ node-version: "18"
- - name: Limit target directory size
- shell: bash -euxo pipefail {0}
- run: script/clear-target-dir-if-larger-than 100
+ - name: Limit target directory size
+ shell: bash -euxo pipefail {0}
+ run: script/clear-target-dir-if-larger-than 100
- - name: Run check
- shell: bash -euxo pipefail {0}
- run: cargo check --tests --workspace
+ - name: Run check
+ shell: bash -euxo pipefail {0}
+ run: cargo check --tests --workspace
- - name: Run tests
- shell: bash -euxo pipefail {0}
- run: cargo nextest run --workspace --no-fail-fast
+ - name: Run tests
+ shell: bash -euxo pipefail {0}
+ run: cargo nextest run --workspace --no-fail-fast
@@ -76,14 +76,6 @@ jobs:
APPLE_NOTARIZATION_USERNAME: ${{ secrets.APPLE_NOTARIZATION_USERNAME }}
APPLE_NOTARIZATION_PASSWORD: ${{ secrets.APPLE_NOTARIZATION_PASSWORD }}
steps:
- - name: Install Rust
- run: |
- rustup set profile minimal
- rustup update stable
- rustup target add aarch64-apple-darwin
- rustup target add x86_64-apple-darwin
- rustup target add wasm32-wasi
-
- name: Install Node
uses: actions/setup-node@v3
with:
@@ -3,41 +3,36 @@ name: Randomized Tests
concurrency: randomized-tests
on:
- push:
- branches:
- - randomized-tests-runner
- # schedule:
- # - cron: '0 * * * *'
+ push:
+ branches:
+ - randomized-tests-runner
+ # schedule:
+ # - cron: '0 * * * *'
env:
- CARGO_TERM_COLOR: always
- CARGO_INCREMENTAL: 0
- RUST_BACKTRACE: 1
- ZED_SERVER_URL: https://zed.dev
- ZED_CLIENT_SECRET_TOKEN: ${{ secrets.ZED_CLIENT_SECRET_TOKEN }}
+ CARGO_TERM_COLOR: always
+ CARGO_INCREMENTAL: 0
+ RUST_BACKTRACE: 1
+ ZED_SERVER_URL: https://zed.dev
+ ZED_CLIENT_SECRET_TOKEN: ${{ secrets.ZED_CLIENT_SECRET_TOKEN }}
jobs:
- tests:
- name: Run randomized tests
- runs-on:
- - self-hosted
- - randomized-tests
- steps:
- - name: Install Rust
- run: |
- rustup set profile minimal
- rustup update stable
+ tests:
+ name: Run randomized tests
+ runs-on:
+ - self-hosted
+ - randomized-tests
+ steps:
+ - name: Install Node
+ uses: actions/setup-node@v3
+ with:
+ node-version: "18"
- - name: Install Node
- uses: actions/setup-node@v3
- with:
- node-version: '18'
+ - name: Checkout repo
+ uses: actions/checkout@v3
+ with:
+ clean: false
+ submodules: "recursive"
- - name: Checkout repo
- uses: actions/checkout@v3
- with:
- clean: false
- submodules: 'recursive'
-
- - name: Run randomized tests
- run: script/randomized-test-ci
+ - name: Run randomized tests
+ run: script/randomized-test-ci
@@ -60,14 +60,6 @@ jobs:
DIGITALOCEAN_SPACES_ACCESS_KEY: ${{ secrets.DIGITALOCEAN_SPACES_ACCESS_KEY }}
DIGITALOCEAN_SPACES_SECRET_KEY: ${{ secrets.DIGITALOCEAN_SPACES_SECRET_KEY }}
steps:
- - name: Install Rust
- run: |
- rustup set profile minimal
- rustup update stable
- rustup target add aarch64-apple-darwin
- rustup target add x86_64-apple-darwin
- rustup target add wasm32-wasi
-
- name: Install Node
uses: actions/setup-node@v3
with:
@@ -8242,7 +8242,6 @@ pub(crate) fn update_test_project_settings(
}
pub(crate) fn init_test(cx: &mut TestAppContext, f: fn(&mut AllLanguageSettingsContent)) {
- dbg!("(???????????");
_ = cx.update(|cx| {
let store = SettingsStore::test(cx);
cx.set_global(store);
@@ -1,4 +1,5 @@
[toolchain]
channel = "1.75"
+profile = "minimal"
components = [ "rustfmt", "clippy" ]
targets = [ "x86_64-apple-darwin", "aarch64-apple-darwin", "wasm32-wasi" ]