Hide editor hovers when a menu is open (#4200)

Conrad Irwin created 2 years ago

Release Notes:

- Fixed a bug where editor hover state could appear while menu open
([#2384](https://github.com/zed-industries/community/issues/2384)).

Change summary

crates/editor/src/element.rs | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

Detailed changes

crates/editor/src/element.rs

@@ -2153,14 +2153,18 @@ impl EditorElement {
                     .max(MIN_POPOVER_LINE_HEIGHT * line_height), // Apply minimum height of 4 lines
             );
 
-            let hover = editor.hover_state.render(
+            let hover = if context_menu.is_some() {
+                None
+            } else {
+                editor.hover_state.render(
                 &snapshot,
                 &style,
                 visible_rows,
                 max_size,
                 editor.workspace.as_ref().map(|(w, _)| w.clone()),
                 cx,
-            );
+            )
+            };
 
             let editor_view = cx.view().clone();
             let fold_indicators = cx.with_element_context(|cx| {