From 4507110981cb0b261945cc904d4d41cf82adee2b Mon Sep 17 00:00:00 2001 From: Bennet Fenner Date: Sun, 19 Oct 2025 17:52:28 +0200 Subject: [PATCH] settings: Remove unused `stream_edits` setting in `agent` (#40640) This setting is unused (we always stream edits) Release Notes: - N/A --- assets/settings/default.json | 2 -- crates/agent_settings/src/agent_settings.rs | 2 -- crates/eval/runner_settings.json | 1 - crates/settings/src/settings_content/agent.rs | 4 ---- 4 files changed, 9 deletions(-) diff --git a/assets/settings/default.json b/assets/settings/default.json index 7433a49ff0fd107fcf02bb691da05319865a56ee..df1ec6fa3a997bae3367b6af7a00262191960983 100644 --- a/assets/settings/default.json +++ b/assets/settings/default.json @@ -884,8 +884,6 @@ // Note: This setting has no effect on external agents that support permission modes, such as Claude Code. // You can set `agent_servers.claude.default_mode` to `bypassPermissions` to skip all permission requests. "always_allow_tool_actions": false, - // When enabled, the agent will stream edits. - "stream_edits": false, // When enabled, agent edits will be displayed in single-file editors for review "single_file_review": true, // When enabled, show voting thumbs for feedback on agent edits. diff --git a/crates/agent_settings/src/agent_settings.rs b/crates/agent_settings/src/agent_settings.rs index 988340318c9f6a68d7b36010eecf0957df145236..c573f2688159619474051e1f7cfefb957f7154a8 100644 --- a/crates/agent_settings/src/agent_settings.rs +++ b/crates/agent_settings/src/agent_settings.rs @@ -41,7 +41,6 @@ pub struct AgentSettings { pub always_allow_tool_actions: bool, pub notify_when_agent_waiting: NotifyWhenAgentWaiting, pub play_sound_when_agent_done: bool, - pub stream_edits: bool, pub single_file_review: bool, pub model_parameters: Vec, pub preferred_completion_mode: CompletionMode, @@ -174,7 +173,6 @@ impl Settings for AgentSettings { always_allow_tool_actions: agent.always_allow_tool_actions.unwrap(), notify_when_agent_waiting: agent.notify_when_agent_waiting.unwrap(), play_sound_when_agent_done: agent.play_sound_when_agent_done.unwrap(), - stream_edits: agent.stream_edits.unwrap(), single_file_review: agent.single_file_review.unwrap(), model_parameters: agent.model_parameters, preferred_completion_mode: agent.preferred_completion_mode.unwrap().into(), diff --git a/crates/eval/runner_settings.json b/crates/eval/runner_settings.json index 91f193d7b3359bdc9ca5a2255f0fb51c4484f344..53d853023c75e78f19c78f797b5751ff79bf1e44 100644 --- a/crates/eval/runner_settings.json +++ b/crates/eval/runner_settings.json @@ -1,7 +1,6 @@ { "assistant": { "always_allow_tool_actions": true, - "stream_edits": true, "version": "2" } } diff --git a/crates/settings/src/settings_content/agent.rs b/crates/settings/src/settings_content/agent.rs index 80326c84688697ab4dcbc83d9013cf3acab26d2b..9d1cd6fed88deb89848a24c890237805b5a8128c 100644 --- a/crates/settings/src/settings_content/agent.rs +++ b/crates/settings/src/settings_content/agent.rs @@ -68,10 +68,6 @@ pub struct AgentSettingsContent { /// /// Default: false pub play_sound_when_agent_done: Option, - /// Whether to stream edits from the agent as they are received. - /// - /// Default: false - pub stream_edits: Option, /// Whether to display agent edits in single-file editors in addition to the review multibuffer pane. /// /// Default: true