From 45d217f6e0a209999007aee0d7ee2914a5677021 Mon Sep 17 00:00:00 2001 From: Bennet Bo Fenner <53836821+bennetbo@users.noreply.github.com> Date: Mon, 29 Apr 2024 12:12:11 +0200 Subject: [PATCH] Set destructive action only when prompt level is set to `Destructive` (#11154) Oversight from #11015, where we added `PromptLevel::Destructive`, which should be used when a prompt performs a "destructive" action (e.g. deleting a file). However, we accidentally set `setHasDestructiveAction` to `true` regardless of which prompt level would be specified Release Notes: - N/A --- crates/gpui/src/platform/mac/window.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/crates/gpui/src/platform/mac/window.rs b/crates/gpui/src/platform/mac/window.rs index 7b57c576f1c63fcec255fcbb260da13fb298fe8e..22ee22b50ba8b63f6f657f0d984b3494982e62db 100644 --- a/crates/gpui/src/platform/mac/window.rs +++ b/crates/gpui/src/platform/mac/window.rs @@ -926,7 +926,6 @@ impl PlatformWindow for MacWindow { if let Some((ix, answer)) = latest_non_cancel_label { let button: id = msg_send![alert, addButtonWithTitle: ns_string(answer)]; let _: () = msg_send![button, setTag: ix as NSInteger]; - let _: () = msg_send![button, setHasDestructiveAction: YES]; if level == PromptLevel::Destructive { let _: () = msg_send![button, setHasDestructiveAction: YES]; }