ci: Remove remaining nextest compiles (#42630)

Lukas Wirth created 1 month ago

Follow up to https://github.com/zed-industries/zed/pull/42556

Release Notes:

- N/A *or* Added/Fixed/Improved ...

Change summary

.github/actions/run_tests/action.yml              | 6 ++----
.github/actions/run_tests_windows/action.yml      | 3 +--
.github/workflows/bump_patch_version.yml          | 2 +-
.github/workflows/compare_perf.yml                | 3 +--
.github/workflows/deploy_collab.yml               | 4 +---
crates/languages/src/rust.rs                      | 2 +-
crates/zed/src/main.rs                            | 4 +++-
tooling/xtask/src/tasks/workflows/compare_perf.rs | 4 ++--
8 files changed, 12 insertions(+), 16 deletions(-)

Detailed changes

.github/actions/run_tests/action.yml

@@ -4,10 +4,8 @@ description: "Runs the tests"
 runs:
   using: "composite"
   steps:
-    - name: Install Rust
-      shell: bash -euxo pipefail {0}
-      run: |
-        cargo install cargo-nextest --locked
+    - name: Install nextest
+      uses: taiki-e/install-action@nextest
 
     - name: Install Node
       uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4

.github/actions/run_tests_windows/action.yml

@@ -11,9 +11,8 @@ runs:
   using: "composite"
   steps:
     - name: Install test runner
-      shell: powershell
       working-directory: ${{ inputs.working-directory }}
-      run: cargo install cargo-nextest --locked
+      uses: taiki-e/install-action@nextest
 
     - name: Install Node
       uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4

.github/workflows/bump_patch_version.yml

@@ -42,7 +42,7 @@ jobs:
               exit 1
               ;;
           esac
-          which cargo-set-version > /dev/null || cargo install cargo-edit
+          which cargo-set-version > /dev/null || cargo install cargo-edit -f --no-default-features --features "set-version"
           output="$(cargo set-version -p zed --bump patch 2>&1 | sed 's/.* //')"
           export GIT_COMMITTER_NAME="Zed Bot"
           export GIT_COMMITTER_EMAIL="[e-mail]"

.github/workflows/compare_perf.yml

@@ -39,8 +39,7 @@ jobs:
       run: ./script/download-wasi-sdk
       shell: bash -euxo pipefail {0}
     - name: compare_perf::run_perf::install_hyperfine
-      run: cargo install hyperfine
-      shell: bash -euxo pipefail {0}
+      uses: taiki-e/install-action@hyperfine
     - name: steps::git_checkout
       run: git fetch origin ${{ inputs.base }} && git checkout ${{ inputs.base }}
       shell: bash -euxo pipefail {0}

.github/workflows/deploy_collab.yml

@@ -43,9 +43,7 @@ jobs:
           fetch-depth: 0
 
       - name: Install cargo nextest
-        shell: bash -euxo pipefail {0}
-        run: |
-          cargo install cargo-nextest --locked
+        uses: taiki-e/install-action@nextest
 
       - name: Limit target directory size
         shell: bash -euxo pipefail {0}

crates/languages/src/rust.rs

@@ -442,7 +442,7 @@ impl LspInstaller for RustLspAdapter {
 
         // It is surprisingly common for ~/.cargo/bin/rust-analyzer to be a symlink to
         // /usr/bin/rust-analyzer that fails when you run it; so we need to test it.
-        log::info!("found rust-analyzer in PATH. trying to run `rust-analyzer --help`");
+        log::debug!("found rust-analyzer in PATH. trying to run `rust-analyzer --help`");
         let result = delegate
             .try_exec(LanguageServerBinary {
                 path: path.clone(),

crates/zed/src/main.rs

@@ -341,7 +341,9 @@ pub fn main() {
         } else {
             None
         };
-    log::info!("Using git binary path: {:?}", git_binary_path);
+    if let Some(git_binary_path) = &git_binary_path {
+        log::info!("Using git binary path: {:?}", git_binary_path);
+    }
 
     let fs = Arc::new(RealFs::new(git_binary_path, app.background_executor()));
     let user_settings_file_rx = watch_config_file(

tooling/xtask/src/tasks/workflows/compare_perf.rs

@@ -35,8 +35,8 @@ pub fn run_perf(base: &Input, head: &Input, crate_name: &Input) -> NamedJob {
         ))
     }
 
-    fn install_hyperfine() -> Step<Run> {
-        named::bash("cargo install hyperfine")
+    fn install_hyperfine() -> Step<Use> {
+        named::uses("taiki-e", "install-action", "hyperfine")
     }
 
     fn compare_runs(head: &Input, base: &Input) -> Step<Run> {