Do not sort settings profiles (#35389)

Joseph T. Lyons created 3 months ago

After playing with this for a bit, I realize it does not feel good to
not have control over the order of profiles. I find myself wanting to
group similar profiles together and not being able to.

Release Notes:

- N/A

Change summary

crates/settings_profile_selector/src/settings_profile_selector.rs | 15 
1 file changed, 6 insertions(+), 9 deletions(-)

Detailed changes

crates/settings_profile_selector/src/settings_profile_selector.rs

@@ -74,13 +74,10 @@ impl SettingsProfileSelectorDelegate {
         cx: &mut Context<SettingsProfileSelector>,
     ) -> Self {
         let settings_store = cx.global::<SettingsStore>();
-        let mut profile_names: Vec<String> = settings_store
+        let mut profile_names: Vec<Option<String>> = settings_store
             .configured_settings_profiles()
-            .map(|s| s.to_string())
+            .map(|s| Some(s.to_string()))
             .collect();
-
-        profile_names.sort();
-        let mut profile_names: Vec<_> = profile_names.into_iter().map(Some).collect();
         profile_names.insert(0, None);
 
         let matches = profile_names
@@ -359,15 +356,15 @@ mod tests {
 
     #[gpui::test]
     async fn test_settings_profile_selector_state(cx: &mut TestAppContext) {
-        let demo_videos_profile_name = "Demo Videos".to_string();
         let classroom_and_streaming_profile_name = "Classroom / Streaming".to_string();
+        let demo_videos_profile_name = "Demo Videos".to_string();
 
         let profiles_json = json!({
-            demo_videos_profile_name.clone(): {
-                "buffer_font_size": 15.0
-            },
             classroom_and_streaming_profile_name.clone(): {
                 "buffer_font_size": 20.0,
+            },
+            demo_videos_profile_name.clone(): {
+                "buffer_font_size": 15.0
             }
         });
         let (workspace, cx) = init_test(profiles_json.clone(), cx).await;