From 4b775505f5891c3dd21e8cd9d5eafc7fa14e7994 Mon Sep 17 00:00:00 2001 From: Smit Barmase Date: Tue, 18 Mar 2025 19:24:24 +0530 Subject: [PATCH] migrator: Fix case where users see migration banner despite no diff changes (#26982) Fixes edge case where after carrying out all migrations if final text is same as existing text, we don't need to ask user to do anything, despite migrations edits are being applied internally. E.g. A -> B - > C -> A Release Notes: - N/A --- crates/migrator/src/migrator.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/migrator/src/migrator.rs b/crates/migrator/src/migrator.rs index e1d5ef0199ea7b4e29a35361746e16eb9828c277..c9d3ecd98d19bd76d2a2831f5b74c45a58f1279d 100644 --- a/crates/migrator/src/migrator.rs +++ b/crates/migrator/src/migrator.rs @@ -77,7 +77,7 @@ fn run_migrations( result = Some(migrated_text); } } - Ok(result) + Ok(result.filter(|new_text| text != new_text)) } pub fn migrate_keymap(text: &str) -> Result> {