Use `Flexible` in file finder and theme switcher instead of `Expanded`

Antonio Scandurra created 4 years ago

Change summary

gpui/src/elements/uniform_list.rs | 2 ++
gpui/src/scene.rs                 | 4 +++-
zed/src/file_finder.rs            | 4 ++--
zed/src/theme_selector.rs         | 7 ++-----
4 files changed, 9 insertions(+), 8 deletions(-)

Detailed changes

gpui/src/elements/uniform_list.rs

@@ -150,6 +150,8 @@ where
             for item in &mut items {
                 item.layout(item_constraint, cx);
             }
+        } else {
+            size = constraint.min;
         }
 
         (

gpui/src/scene.rs

@@ -210,7 +210,9 @@ impl StackingContext {
                 clip_bounds
                     .intersection(parent_clip_bounds.unwrap_or(clip_bounds))
                     .unwrap_or_else(|| {
-                        log::warn!("specified clip bounds are disjoint from parent layer");
+                        if !clip_bounds.is_empty() {
+                            log::warn!("specified clip bounds are disjoint from parent layer");
+                        }
                         RectF::default()
                     })
             })

zed/src/file_finder.rs

@@ -87,7 +87,7 @@ impl View for FileFinder {
                 Container::new(
                     Flex::new(Axis::Vertical)
                         .with_child(ChildView::new(self.query_editor.id()).boxed())
-                        .with_child(Expanded::new(1.0, self.render_matches()).boxed())
+                        .with_child(Flexible::new(1.0, self.render_matches()).boxed())
                         .boxed(),
                 )
                 .with_style(&settings.theme.selector.container)
@@ -173,7 +173,7 @@ impl FileFinder {
                     .boxed(),
                 )
                 .with_child(
-                    Expanded::new(
+                    Flexible::new(
                         1.0,
                         Flex::column()
                             .with_child(

zed/src/theme_selector.rs

@@ -9,10 +9,7 @@ use crate::{
 };
 use gpui::{
     action,
-    elements::{
-        Align, ChildView, ConstrainedBox, Container, Expanded, Flex, Label, ParentElement,
-        UniformList, UniformListState,
-    },
+    elements::*,
     keymap::{self, menu, Binding},
     AppContext, Axis, Element, ElementBox, Entity, MutableAppContext, RenderContext, View,
     ViewContext, ViewHandle,
@@ -283,7 +280,7 @@ impl View for ThemeSelector {
                 Container::new(
                     Flex::new(Axis::Vertical)
                         .with_child(ChildView::new(self.query_editor.id()).boxed())
-                        .with_child(Expanded::new(1.0, self.render_matches(cx)).boxed())
+                        .with_child(Flexible::new(1.0, self.render_matches(cx)).boxed())
                         .boxed(),
                 )
                 .with_style(&settings.theme.selector.container)