From 4d1df7bcd7eb152db875a86f78d7bd87376436f1 Mon Sep 17 00:00:00 2001
From: Richard Feldman <oss@rtfeldman.com>
Date: Fri, 2 May 2025 16:11:16 -0400
Subject: [PATCH] Re-enable directory-related tools (#29809)

Also `now` in `write` profile

Release Notes:

- Tools for manipulating directories no longer require confirmation, and
are enabled in the Write profile
- Enabled `now` and `list_directory` tools by default in Write profile

---------

Co-authored-by: Cole Miller <m@cole-miller.net>
Co-authored-by: Cole Miller <cole@zed.dev>
---
 assets/settings/default.json                        | 11 ++++++-----
 crates/assistant_tools/src/copy_path_tool.rs        |  2 +-
 crates/assistant_tools/src/create_directory_tool.rs |  2 +-
 crates/assistant_tools/src/delete_path_tool.rs      |  2 +-
 crates/assistant_tools/src/move_path_tool.rs        |  2 +-
 5 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/assets/settings/default.json b/assets/settings/default.json
index 593ec7cbbcb65aba2f1cc10731dd3703e07899d5..47b65a7f6bf355d2b6ab4df9711c763b862691d0 100644
--- a/assets/settings/default.json
+++ b/assets/settings/default.json
@@ -669,7 +669,7 @@
           "contents": true,
           "diagnostics": true,
           "fetch": true,
-          "list_directory": false,
+          "list_directory": true,
           "now": true,
           "find_path": true,
           "read_file": true,
@@ -683,15 +683,16 @@
         "name": "Write",
         "enable_all_context_servers": true,
         "tools": {
-          "copy_path": false,
+          "copy_path": true,
+          "create_directory": true,
           "create_file": true,
-          "delete_path": false,
+          "delete_path": true,
           "diagnostics": true,
           "edit_file": true,
           "fetch": true,
           "list_directory": true,
-          "move_path": false,
-          "now": false,
+          "move_path": true,
+          "now": true,
           "find_path": true,
           "read_file": true,
           "grep": true,
diff --git a/crates/assistant_tools/src/copy_path_tool.rs b/crates/assistant_tools/src/copy_path_tool.rs
index 4ea11e999bec6f256959a601ba88ddddd9ae21eb..07d4e583026fd177dc0d9be62307bf347af7be9a 100644
--- a/crates/assistant_tools/src/copy_path_tool.rs
+++ b/crates/assistant_tools/src/copy_path_tool.rs
@@ -45,7 +45,7 @@ impl Tool for CopyPathTool {
     }
 
     fn needs_confirmation(&self, _: &serde_json::Value, _: &App) -> bool {
-        true
+        false
     }
 
     fn description(&self) -> String {
diff --git a/crates/assistant_tools/src/create_directory_tool.rs b/crates/assistant_tools/src/create_directory_tool.rs
index 4ab8546cee87c4a018eb95f3715080770520707f..a0ccd6f425571b13e7323620ac9a4d5cb1f6da19 100644
--- a/crates/assistant_tools/src/create_directory_tool.rs
+++ b/crates/assistant_tools/src/create_directory_tool.rs
@@ -35,7 +35,7 @@ impl Tool for CreateDirectoryTool {
     }
 
     fn needs_confirmation(&self, _: &serde_json::Value, _: &App) -> bool {
-        true
+        false
     }
 
     fn description(&self) -> String {
diff --git a/crates/assistant_tools/src/delete_path_tool.rs b/crates/assistant_tools/src/delete_path_tool.rs
index fcac081e9cbe8e54e34885d48176c537846a609f..f5452d0eb821751ce433f211c41d54492e5ddb67 100644
--- a/crates/assistant_tools/src/delete_path_tool.rs
+++ b/crates/assistant_tools/src/delete_path_tool.rs
@@ -34,7 +34,7 @@ impl Tool for DeletePathTool {
     }
 
     fn needs_confirmation(&self, _: &serde_json::Value, _: &App) -> bool {
-        true
+        false
     }
 
     fn description(&self) -> String {
diff --git a/crates/assistant_tools/src/move_path_tool.rs b/crates/assistant_tools/src/move_path_tool.rs
index 89691694a6f32766259faf76fc4b7090d9658986..9c9493c4f53cf52a7d0fea648a354b28088ff547 100644
--- a/crates/assistant_tools/src/move_path_tool.rs
+++ b/crates/assistant_tools/src/move_path_tool.rs
@@ -43,7 +43,7 @@ impl Tool for MovePathTool {
     }
 
     fn needs_confirmation(&self, _: &serde_json::Value, _: &App) -> bool {
-        true
+        false
     }
 
     fn description(&self) -> String {