From 4f364d6d09877ff95371f9cd0c886c271d9f48bf Mon Sep 17 00:00:00 2001 From: Conrad Irwin Date: Tue, 18 Jun 2024 13:48:26 -0600 Subject: [PATCH] Hide old linux panics (#13221) Remove noise from the #panics channel by excluding any linux build before 0.139.x. We filter on the os_version and os_name because evern older versions of linux set app_version = 1.0.0. Release Notes: - N/A --- crates/collab/src/api/events.rs | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/crates/collab/src/api/events.rs b/crates/collab/src/api/events.rs index 5456ae7ab20fd69cae442d1533606ad96a906d2a..c3b7a21a92cf2b6257ba65677141c26ebf95a0db 100644 --- a/crates/collab/src/api/events.rs +++ b/crates/collab/src/api/events.rs @@ -308,13 +308,12 @@ pub async fn post_panic( .map_err(|_| Error::Http(StatusCode::BAD_REQUEST, "invalid json".into()))?; let panic = report.panic; - // better OS reporting for linux (because linux is hard): - // - Remove os_version/app_version/os_name from the gpui platform trait - // - Move platform processing data into client/telemetry - // - Duplicate some small code in macOS platform for a version check - // - Add GPUI API for reporting the selected platform integration - // - macos-blade, macos-metal, linux-X11, linux-headless - // if cfg(macos( { "Macos" } else { "Linux-{cx.compositor_name()"} )) + if panic.os_name == "Linux" && panic.os_version == Some("1.0.0".to_string()) { + return Err(Error::Http( + StatusCode::BAD_REQUEST, + "invalid os version".into(), + ))?; + } tracing::error!( service = "client",