Enable `clippy::map_identity` (#8731)

Marshall Bowers created 2 years ago

This PR enables the
[`clippy::map_identity`](https://rust-lang.github.io/rust-clippy/master/index.html#/map_identity)
rule and fixes the outstanding violations.

Release Notes:

- N/A

Change summary

crates/lsp/src/lsp.rs         | 2 +-
crates/project/src/project.rs | 4 ++--
tooling/xtask/src/main.rs     | 1 -
3 files changed, 3 insertions(+), 4 deletions(-)

Detailed changes

crates/lsp/src/lsp.rs

@@ -340,7 +340,7 @@ impl LanguageServer {
             io_tasks: Mutex::new(Some((input_task, output_task))),
             output_done_rx: Mutex::new(Some(output_done_rx)),
             root_path: root_path.to_path_buf(),
-            server: Arc::new(Mutex::new(server.map(|server| server))),
+            server: Arc::new(Mutex::new(server)),
         }
     }
 

crates/project/src/project.rs

@@ -3665,7 +3665,7 @@ impl Project {
                                 proto::LspWorkStart {
                                     token,
                                     message: report.message,
-                                    percentage: report.percentage.map(|p| p),
+                                    percentage: report.percentage,
                                 },
                             ),
                         })
@@ -3691,7 +3691,7 @@ impl Project {
                                 proto::LspWorkProgress {
                                     token,
                                     message: report.message,
-                                    percentage: report.percentage.map(|p| p),
+                                    percentage: report.percentage,
                                 },
                             ),
                         })

tooling/xtask/src/main.rs

@@ -105,7 +105,6 @@ fn run_clippy(args: ClippyArgs) -> Result<()> {
         "clippy::manual_flatten",
         "clippy::map_entry",
         "clippy::map_flatten",
-        "clippy::map_identity",
         "clippy::needless_arbitrary_self_type",
         "clippy::needless_borrowed_reference",
         "clippy::needless_lifetimes",