From 5259b24896bf1aa29729f459d5f28b300e0d59e1 Mon Sep 17 00:00:00 2001 From: Austin Cummings Date: Thu, 5 Feb 2026 15:04:21 -0700 Subject: [PATCH] settings_ui: Fix tab navigation in edit predictions settings (#48530) The provider dropdown and GitHub Copilot sign-in button were not tab-navigable because they lacked tab_index. The copilot button conditionally sets tab_index only when edit_prediction is true, since it's also used in the agent configuration panel where tab navigation isn't used. Closes #48391 Release Notes: - Fixed focus skipping provider dropdown and GitHub Copilot button in edit prediction settings --- crates/copilot_ui/src/sign_in.rs | 1 + crates/settings_ui/src/pages/edit_prediction_provider_setup.rs | 1 + 2 files changed, 2 insertions(+) diff --git a/crates/copilot_ui/src/sign_in.rs b/crates/copilot_ui/src/sign_in.rs index d5224280af8418c02c9bd46685f42f7a989236f8..b6f12ea899d08221ec02ab216cbb673056d0b3f2 100644 --- a/crates/copilot_ui/src/sign_in.rs +++ b/crates/copilot_ui/src/sign_in.rs @@ -568,6 +568,7 @@ impl ConfigurationView { .icon_color(Color::Muted) .icon_position(IconPosition::Start) .icon_size(IconSize::Small) + .when(edit_prediction, |this| this.tab_index(0isize)) .on_click(|_, window, cx| { if let Some(app_state) = AppState::global(cx).upgrade() && let Some(copilot) = GlobalCopilotAuth::try_get_or_init(app_state, cx) diff --git a/crates/settings_ui/src/pages/edit_prediction_provider_setup.rs b/crates/settings_ui/src/pages/edit_prediction_provider_setup.rs index b88a355d6779d0273b291b8b31a5041268d7e416..eaf362685f73421bfdfe988a361869d66611c3e6 100644 --- a/crates/settings_ui/src/pages/edit_prediction_provider_setup.rs +++ b/crates/settings_ui/src/pages/edit_prediction_provider_setup.rs @@ -157,6 +157,7 @@ fn render_provider_dropdown(window: &mut Window, cx: &mut App) -> AnyElement { ) .child( DropdownMenu::new("provider-dropdown", current_provider_name, menu) + .tab_index(0) .style(DropdownStyle::Outlined), ), )