From 530225a06a4a4ddff95972ee52441901b5f6ad56 Mon Sep 17 00:00:00 2001 From: Peter Tripp Date: Thu, 18 Sep 2025 16:40:06 -0400 Subject: [PATCH] python: Remove a redundant pip install call (#38449) I confirmed that the pip packages match for: ```sh pip install python-lsp-server && pip install 'python-lsp-server[all]' pip install 'python-lsp-server[all]' ``` Originally introduced here: - https://github.com/zed-industries/zed/pull/20358 Release Notes: - N/A --- crates/languages/src/python.rs | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/crates/languages/src/python.rs b/crates/languages/src/python.rs index 4451054cfd21be5d07c9df64b55a37ffc190670f..91c1c675f8090d9d0161b6d3733d34ed386cfb50 100644 --- a/crates/languages/src/python.rs +++ b/crates/languages/src/python.rs @@ -1555,17 +1555,6 @@ impl LspInstaller for PyLspAdapter { ) -> Result { let venv = self.base_venv(delegate).await.map_err(|e| anyhow!(e))?; let pip_path = venv.join(BINARY_DIR).join("pip3"); - ensure!( - util::command::new_smol_command(pip_path.as_path()) - .arg("install") - .arg("python-lsp-server") - .arg("--upgrade") - .output() - .await? - .status - .success(), - "python-lsp-server installation failed" - ); ensure!( util::command::new_smol_command(pip_path.as_path()) .arg("install")