dev_container: Fix environment variables without an equals sign were treated as fatal parsing errors. (#53864)

Bing Wang created 5 days ago

in vscode the environment variables without an equals sign are ignored
https://github.com/devcontainers/cli/blob/main/src/spec-node/utils.ts#L488-L498
Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes #53470

Release Notes:

- Fix environment variables without an equals sign were treated as fatal
parsing errors.

Change summary

crates/dev_container/src/docker.rs | 42 ++++++++++++++++++++++++++++++-
1 file changed, 40 insertions(+), 2 deletions(-)

Detailed changes

crates/dev_container/src/docker.rs

@@ -57,8 +57,8 @@ impl DockerInspectConfig {
         let mut map = HashMap::new();
         for env_var in &self.env {
             let Some((key, value)) = env_var.split_once('=') else {
-                log::error!("Unable to parse {env_var} into an environment key-value");
-                return Err(DevContainerError::DevContainerParseFailed);
+                log::warn!("Skipping environment variable without a value: {env_var}");
+                continue;
             };
             map.insert(key.to_string(), value.to_string());
         }
@@ -563,6 +563,44 @@ mod test {
         assert_eq!(map.get("COMPLEX").unwrap(), "key=val other>=1.0");
     }
 
+    #[test]
+    fn should_parse_database_url_with_equals_in_query_string() {
+        let config = super::DockerInspectConfig {
+            labels: super::DockerConfigLabels { metadata: None },
+            image_user: None,
+            env: vec![
+                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin".to_string(),
+                "TEST_DATABASE_URL=postgres://postgres:postgres@db:5432/mydb?sslmode=disable"
+                    .to_string(),
+            ],
+        };
+
+        let map = config.env_as_map().unwrap();
+        assert_eq!(
+            map.get("TEST_DATABASE_URL").unwrap(),
+            "postgres://postgres:postgres@db:5432/mydb?sslmode=disable"
+        );
+    }
+
+    #[test]
+    fn should_skip_env_var_without_equals() {
+        let config = super::DockerInspectConfig {
+            labels: super::DockerConfigLabels { metadata: None },
+            image_user: None,
+            env: vec![
+                "VALID_KEY=valid_value".to_string(),
+                "NO_EQUALS_VAR".to_string(),
+                "ANOTHER_VALID=value".to_string(),
+            ],
+        };
+
+        let map = config.env_as_map().unwrap();
+        assert_eq!(map.len(), 2);
+        assert_eq!(map.get("VALID_KEY").unwrap(), "valid_value");
+        assert_eq!(map.get("ANOTHER_VALID").unwrap(), "value");
+        assert!(!map.contains_key("NO_EQUALS_VAR"));
+    }
+
     #[test]
     fn should_parse_simple_label() {
         let json = r#"{"volumes": [], "labels": ["com.example.key=value"]}"#;