From 563a1dcbab67b58a6c9cf10fe4dea35d862376d1 Mon Sep 17 00:00:00 2001 From: Max Brunsfeld Date: Tue, 1 Oct 2024 12:58:21 -0600 Subject: [PATCH] Fix panic when opening proposed changes editor with reversed ranges (#18599) Closes https://github.com/zed-industries/zed/issues/18589 Release Notes: - N/A Co-authored-by: Antonio --- crates/editor/src/editor.rs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/crates/editor/src/editor.rs b/crates/editor/src/editor.rs index 54a1318bdfe52cfb4f92cac2a53d754c83f4bc94..ddc7de4e41a464143c8bba11eb835e583d015697 100644 --- a/crates/editor/src/editor.rs +++ b/crates/editor/src/editor.rs @@ -12257,12 +12257,9 @@ impl Editor { let buffer = self.buffer.read(cx); let mut new_selections_by_buffer = HashMap::default(); for selection in self.selections.all::(cx) { - for (buffer, mut range, _) in + for (buffer, range, _) in buffer.range_to_buffer_ranges(selection.start..selection.end, cx) { - if selection.reversed { - mem::swap(&mut range.start, &mut range.end); - } let mut range = range.to_point(buffer.read(cx)); range.start.column = 0; range.end.column = buffer.read(cx).line_len(range.end.row);