Enable `clippy::needless_option_as_deref` (#8775)

Marshall Bowers created 2 years ago

This PR enables the
[`clippy::needless_option_as_deref`](https://rust-lang.github.io/rust-clippy/master/index.html#/needless_option_as_deref)
rule and fixes the outstanding violations.

Release Notes:

- N/A

Change summary

crates/editor/src/display_map.rs | 2 +-
tooling/xtask/src/main.rs        | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)

Detailed changes

crates/editor/src/display_map.rs

@@ -326,7 +326,7 @@ impl DisplayMap {
             .read(cx)
             .as_singleton()
             .and_then(|buffer| buffer.read(cx).language());
-        language_settings(language.as_deref(), None, cx).tab_size
+        language_settings(language, None, cx).tab_size
     }
 
     #[cfg(test)]

tooling/xtask/src/main.rs

@@ -96,7 +96,6 @@ fn run_clippy(args: ClippyArgs) -> Result<()> {
         "clippy::let_underscore_future",
         "clippy::map_entry",
         "clippy::needless_lifetimes",
-        "clippy::needless_option_as_deref",
         "clippy::needless_update",
         "clippy::never_loop",
         "clippy::non_canonical_clone_impl",