From ad31c284c78449c05a2ae28dc1d918c05bb9a56c Mon Sep 17 00:00:00 2001 From: Kay Simmons Date: Tue, 8 Nov 2022 14:22:11 -0800 Subject: [PATCH 1/3] remove restart to update zed icon because it clashes with the no diagnostics icon --- crates/activity_indicator/src/activity_indicator.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/crates/activity_indicator/src/activity_indicator.rs b/crates/activity_indicator/src/activity_indicator.rs index cc788c1e482d58a9a49425e9e46adc288368f5a9..efb7f7d39c7cbbdd9c14dfc47468664420242959 100644 --- a/crates/activity_indicator/src/activity_indicator.rs +++ b/crates/activity_indicator/src/activity_indicator.rs @@ -254,9 +254,7 @@ impl ActivityIndicator { "Installing Zed update…".to_string(), None, ), - AutoUpdateStatus::Updated => { - (Some(DONE_ICON), "Restart to update Zed".to_string(), None) - } + AutoUpdateStatus::Updated => (None, "Restart to update Zed".to_string(), None), AutoUpdateStatus::Errored => ( Some(WARNING_ICON), "Auto update failed".to_string(), From cea103e47c6574de9002f17b7169d33e9ecc95b6 Mon Sep 17 00:00:00 2001 From: Kay Simmons Date: Tue, 8 Nov 2022 14:24:51 -0800 Subject: [PATCH 2/3] remove dead comment --- crates/activity_indicator/src/activity_indicator.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/crates/activity_indicator/src/activity_indicator.rs b/crates/activity_indicator/src/activity_indicator.rs index efb7f7d39c7cbbdd9c14dfc47468664420242959..84cc4faca2f64a43a10bc42ac6e0f41e19fbc965 100644 --- a/crates/activity_indicator/src/activity_indicator.rs +++ b/crates/activity_indicator/src/activity_indicator.rs @@ -237,7 +237,6 @@ impl ActivityIndicator { // Show any application auto-update info. if let Some(updater) = &self.auto_updater { - // let theme = &cx.global::().theme.workspace.status_bar; match &updater.read(cx).status() { AutoUpdateStatus::Checking => ( Some(DOWNLOAD_ICON), From bbeb6857695bcaa07645a865e5d7e69b21a38c7f Mon Sep 17 00:00:00 2001 From: Kay Simmons Date: Tue, 8 Nov 2022 14:26:55 -0800 Subject: [PATCH 3/3] remove unused comment --- crates/activity_indicator/src/activity_indicator.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/crates/activity_indicator/src/activity_indicator.rs b/crates/activity_indicator/src/activity_indicator.rs index 84cc4faca2f64a43a10bc42ac6e0f41e19fbc965..775e460a2d454d8ffa15d529ebdf1c18d109de20 100644 --- a/crates/activity_indicator/src/activity_indicator.rs +++ b/crates/activity_indicator/src/activity_indicator.rs @@ -17,7 +17,6 @@ actions!(lsp_status, [ShowErrorMessage]); const DOWNLOAD_ICON: &str = "icons/download_12.svg"; const WARNING_ICON: &str = "icons/triangle_exclamation_12.svg"; -const DONE_ICON: &str = "icons/circle_check_12.svg"; pub enum Event { ShowError { lsp_name: Arc, error: String },