Revert "Accept edit predictions with `alt-tab` in addition to `tab` (#24272)"

Marshall Bowers created 11 months ago

This reverts commit eafad7d9db9dead3561e19070ff71a93f26f602a.

Change summary

assets/keymaps/default-linux.json | 12 ++++++------
assets/keymaps/default-macos.json | 12 ++++++------
2 files changed, 12 insertions(+), 12 deletions(-)

Detailed changes

assets/keymaps/default-linux.json

@@ -503,17 +503,17 @@
     }
   },
   {
-    "context": "Editor && inline_completion",
+    "context": "Editor && inline_completion && !showing_completions",
+    "use_key_equivalents": true,
     "bindings": {
-      // Changing the modifier currently breaks accepting while you also an LSP completions menu open
-      "alt-enter": "editor::AcceptInlineCompletion"
+      "tab": "editor::AcceptInlineCompletion"
     }
   },
   {
-    "context": "Editor && inline_completion && !showing_completions",
-    "use_key_equivalents": true,
+    "context": "Editor && inline_completion && showing_completions",
     "bindings": {
-      "tab": "editor::AcceptInlineCompletion"
+      // Currently, changing this binding breaks the preview behavior
+      "alt-enter": "editor::AcceptInlineCompletion"
     }
   },
   {

assets/keymaps/default-macos.json

@@ -580,17 +580,17 @@
     }
   },
   {
-    "context": "Editor && inline_completion",
+    "context": "Editor && inline_completion && !showing_completions",
+    "use_key_equivalents": true,
     "bindings": {
-      // Changing the modifier currently breaks accepting while you also an LSP completions menu open
-      "alt-tab": "editor::AcceptInlineCompletion"
+      "tab": "editor::AcceptInlineCompletion"
     }
   },
   {
-    "context": "Editor && inline_completion && !showing_completions",
-    "use_key_equivalents": true,
+    "context": "Editor && inline_completion && showing_completions",
     "bindings": {
-      "tab": "editor::AcceptInlineCompletion"
+      // Currently, changing this binding breaks the preview behavior
+      "alt-tab": "editor::AcceptInlineCompletion"
     }
   },
   {