From 5e41ce17e35685de1f62662e96f6de0b9cef8749 Mon Sep 17 00:00:00 2001 From: Kirill Bulatov Date: Tue, 4 Nov 2025 00:42:26 +0200 Subject: [PATCH] Do not pull diagnostics when those are disabled (#41865) Based on [hang.log](https://github.com/user-attachments/files/23319081/hang.log) Release Notes: - N/A --- crates/editor/src/editor.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crates/editor/src/editor.rs b/crates/editor/src/editor.rs index 50102a685f93abac91341539ef51445cb80c6403..2d9afd3721a8165caae4cd15a14b2448f1bc7cfa 100644 --- a/crates/editor/src/editor.rs +++ b/crates/editor/src/editor.rs @@ -17847,6 +17847,7 @@ impl Editor { .unwrap_or(self.diagnostics_max_severity); if !self.inline_diagnostics_enabled() + || !self.diagnostics_enabled() || !self.show_inline_diagnostics || max_severity == DiagnosticSeverity::Off { @@ -17925,7 +17926,7 @@ impl Editor { window: &Window, cx: &mut Context, ) -> Option<()> { - if self.ignore_lsp_data() { + if self.ignore_lsp_data() || !self.diagnostics_enabled() { return None; } let pull_diagnostics_settings = ProjectSettings::get_global(cx)