ui: Fix panic in `highlight_ranges` when given an oob index (#39051)

Lukas Wirth created 1 month ago

Fixes ZED-1QW

Release Notes:

- Fixed a panic when highlighting labels

Change summary

crates/ui/src/components/label/highlighted_label.rs | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)

Detailed changes

crates/ui/src/components/label/highlighted_label.rs

@@ -97,15 +97,10 @@ pub fn highlight_ranges(
         let mut end_ix = start_ix;
 
         loop {
-            end_ix = end_ix + text[end_ix..].chars().next().unwrap().len_utf8();
-            if let Some(&next_ix) = highlight_indices.peek()
-                && next_ix == end_ix
-            {
-                end_ix = next_ix;
-                highlight_indices.next();
-                continue;
+            end_ix += text[end_ix..].chars().next().map_or(0, |c| c.len_utf8());
+            if highlight_indices.next_if(|&ix| ix == end_ix).is_none() {
+                break;
             }
-            break;
         }
 
         highlights.push((start_ix..end_ix, style));