From 4966a4a681d4a79a8222eca1434f45e6f33fe925 Mon Sep 17 00:00:00 2001 From: Julia Date: Mon, 1 May 2023 13:14:35 -0400 Subject: [PATCH 1/2] Reduce hardcoded ESLint workspace configuration --- crates/zed/src/languages/typescript.rs | 33 ++++---------------------- 1 file changed, 4 insertions(+), 29 deletions(-) diff --git a/crates/zed/src/languages/typescript.rs b/crates/zed/src/languages/typescript.rs index 54d61e91cae5975198c34fedb93e8551ce0ddc08..429a5d942151cd9dbd3661b2ebb6bbc16a6505e3 100644 --- a/crates/zed/src/languages/typescript.rs +++ b/crates/zed/src/languages/typescript.rs @@ -188,35 +188,10 @@ impl LspAdapter for EsLintLspAdapter { Some( future::ready(json!({ "": { - "validate": "on", - "packageManager": "npm", - "useESLintClass": false, - "experimental": { - "useFlatConfig": false - }, - "codeActionOnSave": { - "mode": "all" - }, - "format": false, - "quiet": false, - "onIgnoredFiles": "off", - "options": {}, - "rulesCustomizations": [], - "run": "onType", - "problems": { - "shortenToSingleLine": false - }, - "nodePath": null, - "codeAction": { - "disableRuleComment": { - "enable": true, - "location": "separateLine", - "commentStyle": "line" - }, - "showDocumentation": { - "enable": true - } - } + "validate": "on", + "rulesCustomizations": [], + "run": "onType", + "nodePath": null, } })) .boxed(), From 40ab5c1fb9ef08101f0e7fcd5eb656b1973aabf8 Mon Sep 17 00:00:00 2001 From: Julia Date: Mon, 1 May 2023 13:15:41 -0400 Subject: [PATCH 2/2] Remove underline from diagnostic source --- styles/src/styleTree/hoverPopover.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/styles/src/styleTree/hoverPopover.ts b/styles/src/styleTree/hoverPopover.ts index fadd62db1d4cc1732a14b4459f2c3eea28891e71..b01402e069804f0ae464a49777de432c9271d175 100644 --- a/styles/src/styleTree/hoverPopover.ts +++ b/styles/src/styleTree/hoverPopover.ts @@ -40,7 +40,7 @@ export default function HoverPopover(colorScheme: ColorScheme) { padding: { top: 4 }, }, prose: text(layer, "sans", { size: "sm" }), - diagnosticSourceHighlight: { underline: true, color: foreground(layer, "accent") }, + diagnosticSourceHighlight: { color: foreground(layer, "accent") }, highlight: colorScheme.ramps.neutral(0.5).alpha(0.2).hex(), // TODO: blend was used here. Replace with something better } }