From 5fff524870c566c073be507c3e15477cf93537b0 Mon Sep 17 00:00:00 2001 From: Thorsten Ball Date: Wed, 18 Sep 2024 12:34:10 +0200 Subject: [PATCH] go: Fix tasks when running tests/benchs in packages (#17998) Turns out that #17645 reintroduced another regression and didn't catch all the regressions in #17108. Releases Notes: - Fixed Go tasks not working properly when running tests or benchmarks in subfolders/packages. Co-authored-by: Piotr --- crates/languages/src/go.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/crates/languages/src/go.rs b/crates/languages/src/go.rs index a528f4f70cdc44bb30bd607c0b04846a72186255..0a51e88715882cbd63aa74c0a08502b69aa7022e 100644 --- a/crates/languages/src/go.rs +++ b/crates/languages/src/go.rs @@ -521,7 +521,6 @@ impl ContextProvider for GoContextProvider { command: "go".into(), args: vec![ "test".into(), - GO_PACKAGE_TASK_VARIABLE.template_value(), "-run".into(), format!("^{}\\$", VariableName::Symbol.template_value(),), ], @@ -532,7 +531,7 @@ impl ContextProvider for GoContextProvider { TaskTemplate { label: format!("go test {}", GO_PACKAGE_TASK_VARIABLE.template_value()), command: "go".into(), - args: vec!["test".into(), GO_PACKAGE_TASK_VARIABLE.template_value()], + args: vec!["test".into()], cwd: package_cwd.clone(), ..TaskTemplate::default() }, @@ -574,7 +573,6 @@ impl ContextProvider for GoContextProvider { command: "go".into(), args: vec![ "test".into(), - GO_PACKAGE_TASK_VARIABLE.template_value(), "-benchmem".into(), "-run=^$".into(), "-bench".into(),