From 625a4b90a50e4cc01198d86b0e16fbe43f5b815e Mon Sep 17 00:00:00 2001 From: Mikayla Maki Date: Fri, 11 Jul 2025 12:02:40 -0700 Subject: [PATCH] Tinker with the reporting of telemetry events (#34239) Release Notes: - N/A --------- Co-authored-by: Katie Geer --- crates/editor/src/editor.rs | 5 ++++- crates/editor/src/items.rs | 8 +++++++- crates/title_bar/src/onboarding_banner.rs | 6 ++++-- 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/crates/editor/src/editor.rs b/crates/editor/src/editor.rs index 63dc857891790bb61dc985caa5db2c091bd4e27c..a25a96cdabd30d43a60b6ab61b2e0ed2e3e41de7 100644 --- a/crates/editor/src/editor.rs +++ b/crates/editor/src/editor.rs @@ -2322,7 +2322,10 @@ impl Editor { editor.update_lsp_data(false, None, window, cx); } - editor.report_editor_event("Editor Opened", None, cx); + if editor.mode.is_full() { + editor.report_editor_event("Editor Opened", None, cx); + } + editor } diff --git a/crates/editor/src/items.rs b/crates/editor/src/items.rs index 2e4631a62b16db51476c5ce5918bdc973806381e..4e6e471f48ed9841c15463d3760be9d55664eefa 100644 --- a/crates/editor/src/items.rs +++ b/crates/editor/src/items.rs @@ -813,7 +813,13 @@ impl Item for Editor { window: &mut Window, cx: &mut Context, ) -> Task> { - self.report_editor_event("Editor Saved", None, cx); + // Add meta data tracking # of auto saves + if options.autosave { + self.report_editor_event("Editor Autosaved", None, cx); + } else { + self.report_editor_event("Editor Saved", None, cx); + } + let buffers = self.buffer().clone().read(cx).all_buffers(); let buffers = buffers .into_iter() diff --git a/crates/title_bar/src/onboarding_banner.rs b/crates/title_bar/src/onboarding_banner.rs index 8ed6e956af4a5789708d1f1995f6fe82aee5dc96..e7cf0cd2d9326b68973935a7815ef281a01b03c3 100644 --- a/crates/title_bar/src/onboarding_banner.rs +++ b/crates/title_bar/src/onboarding_banner.rs @@ -51,7 +51,6 @@ impl OnboardingBanner { } fn dismiss(&mut self, cx: &mut Context) { - telemetry::event!("Banner Dismissed", source = self.source); persist_dismissed(&self.source, cx); self.dismissed = true; cx.notify(); @@ -144,7 +143,10 @@ impl Render for OnboardingBanner { div().border_l_1().border_color(border_color).child( IconButton::new("close", IconName::Close) .icon_size(IconSize::Indicator) - .on_click(cx.listener(|this, _, _window, cx| this.dismiss(cx))) + .on_click(cx.listener(|this, _, _window, cx| { + telemetry::event!("Banner Dismissed", source = this.source); + this.dismiss(cx) + })) .tooltip(|window, cx| { Tooltip::with_meta( "Close Announcement Banner",