From 6265305248055161a820d729741cb6949cc99254 Mon Sep 17 00:00:00 2001 From: Finn Evers Date: Mon, 19 Jan 2026 20:58:10 +0100 Subject: [PATCH] extension_host: Fix extension rebuild building in release mode (#47165) Release Notes: - Fixed an issue where rebuilding a dev extension would compile the extension in release and not debug mode. --- crates/extension/src/extension_builder.rs | 6 ++++++ crates/extension_host/src/extension_host.rs | 9 ++------- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/crates/extension/src/extension_builder.rs b/crates/extension/src/extension_builder.rs index 8b9bf994d17e0594c719bed29907630fedf11497..fe4477e227c17d42110e55412f8f1583859227be 100644 --- a/crates/extension/src/extension_builder.rs +++ b/crates/extension/src/extension_builder.rs @@ -55,6 +55,12 @@ pub struct CompileExtensionOptions { pub release: bool, } +impl CompileExtensionOptions { + pub const fn dev() -> Self { + Self { release: false } + } +} + #[derive(Deserialize)] struct CargoToml { package: CargoTomlPackage, diff --git a/crates/extension_host/src/extension_host.rs b/crates/extension_host/src/extension_host.rs index 219b72f92d1588422c6eec818fd3f73acd044907..80b11a5229fe52e898450212b405f717394a7b56 100644 --- a/crates/extension_host/src/extension_host.rs +++ b/crates/extension_host/src/extension_host.rs @@ -981,7 +981,7 @@ impl ExtensionStore { .compile_extension( &extension_source_path, &mut extension_manifest, - CompileExtensionOptions { release: false }, + CompileExtensionOptions::dev(), fs, ) .await @@ -1041,12 +1041,7 @@ impl ExtensionStore { let compile = cx.background_spawn(async move { let mut manifest = ExtensionManifest::load(fs.clone(), &path).await?; builder - .compile_extension( - &path, - &mut manifest, - CompileExtensionOptions { release: true }, - fs, - ) + .compile_extension(&path, &mut manifest, CompileExtensionOptions::dev(), fs) .await });