Move character counter up above editor in feedback modal

Joseph T. Lyons created 2 years ago

Change summary

crates/feedback2/src/feedback_modal.rs | 46 ++++++++++++++--------------
1 file changed, 23 insertions(+), 23 deletions(-)

Detailed changes

crates/feedback2/src/feedback_modal.rs

@@ -301,6 +301,29 @@ impl Render for FeedbackModal {
                 // TODO: Add Headline component to `ui2`
                 div().text_xl().child("Share Feedback"),
             ))
+            .child(
+                Label::new(if self.character_count < *FEEDBACK_CHAR_LIMIT.start() {
+                    format!(
+                        "Feedback must be at least {} characters.",
+                        FEEDBACK_CHAR_LIMIT.start()
+                    )
+                } else if self.character_count > *FEEDBACK_CHAR_LIMIT.end() {
+                    format!(
+                        "Feedback must be less than {} characters.",
+                        FEEDBACK_CHAR_LIMIT.end()
+                    )
+                } else {
+                    format!(
+                        "Characters: {}",
+                        *FEEDBACK_CHAR_LIMIT.end() - self.character_count
+                    )
+                })
+                .color(if valid_character_count {
+                    Color::Success
+                } else {
+                    Color::Error
+                }),
+            )
             .child(
                 div()
                     .flex_1()
@@ -313,29 +336,6 @@ impl Render for FeedbackModal {
             )
             .child(
                 div()
-                    .child(
-                        Label::new(if self.character_count < *FEEDBACK_CHAR_LIMIT.start() {
-                            format!(
-                                "Feedback must be at least {} characters.",
-                                FEEDBACK_CHAR_LIMIT.start()
-                            )
-                        } else if self.character_count > *FEEDBACK_CHAR_LIMIT.end() {
-                            format!(
-                                "Feedback must be less than {} characters.",
-                                FEEDBACK_CHAR_LIMIT.end()
-                            )
-                        } else {
-                            format!(
-                                "Characters: {}",
-                                *FEEDBACK_CHAR_LIMIT.end() - self.character_count
-                            )
-                        })
-                        .color(if valid_character_count {
-                            Color::Success
-                        } else {
-                            Color::Error
-                        }),
-                    )
                     .child(
                         h_stack()
                             .bg(cx.theme().colors().editor_background)