Remove redundant env var filtering in TerminalBuilder

Richard Feldman created 1 month ago

The sandbox_exec_main wrapper already scrubs the inherited process
environment before exec-ing the real shell. The TerminalBuilder
filtering only pruned the additive env HashMap, not the inherited
environment, so it was both redundant and incomplete. The single
filtering point in sandbox_exec_main is the authoritative one.

Change summary

crates/terminal/src/terminal.rs | 20 --------------------
1 file changed, 20 deletions(-)

Detailed changes

crates/terminal/src/terminal.rs

@@ -470,26 +470,6 @@ impl TerminalBuilder {
 
             insert_zed_terminal_env(&mut env, &version);
 
-            // When sandbox is enabled, filter env vars to only the allowed set.
-            // Zed-specific vars (inserted above) are always kept.
-            if let Some(ref sandbox) = sandbox_config {
-                let allowed: collections::HashSet<&str> = sandbox
-                    .allowed_env_vars
-                    .iter()
-                    .map(|s| s.as_str())
-                    .collect();
-                let zed_vars = [
-                    "ZED_TERM",
-                    "TERM_PROGRAM",
-                    "TERM",
-                    "COLORTERM",
-                    "TERM_PROGRAM_VERSION",
-                ];
-                env.retain(|key, _| {
-                    allowed.contains(key.as_str()) || zed_vars.contains(&key.as_str())
-                });
-            }
-
             #[derive(Default)]
             struct ShellParams {
                 program: String,