From 6707ff3b5071893aecd459851800efe197879bf6 Mon Sep 17 00:00:00 2001 From: Finn Evers Date: Fri, 3 Oct 2025 21:20:51 +0200 Subject: [PATCH] Make outline modal work in channel notes (#39481) This fixes an issue where the outline modal would not work in editors that had no explicit workspace attached to them. Release Notes: - Enabled the outline modal to work in channel notes. --- crates/outline/src/outline.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/crates/outline/src/outline.rs b/crates/outline/src/outline.rs index 8d215720a1f0ec82a2cac018d3d43c4c0a35e98e..ac74d6284f4fe2fe62bcad7be447b142255056b4 100644 --- a/crates/outline/src/outline.rs +++ b/crates/outline/src/outline.rs @@ -20,7 +20,7 @@ use settings::Settings; use theme::{ActiveTheme, ThemeSettings}; use ui::{ListItem, ListItemSpacing, prelude::*}; use util::ResultExt; -use workspace::{DismissDecision, ModalView}; +use workspace::{DismissDecision, ModalView, Workspace}; pub fn init(cx: &mut App) { cx.observe_new(OutlineView::register).detach(); @@ -48,7 +48,8 @@ pub fn toggle( .snapshot(cx) .outline(Some(cx.theme().syntax())); - if let Some((workspace, outline)) = editor.read(cx).workspace().zip(outline) { + let workspace = window.root::().flatten(); + if let Some((workspace, outline)) = workspace.zip(outline) { workspace.update(cx, |workspace, cx| { workspace.toggle_modal(window, cx, |window, cx| { OutlineView::new(outline, editor, window, cx)