From 670ade9546df980b54af54079de47d46cdb18628 Mon Sep 17 00:00:00 2001 From: Marshall Bowers Date: Wed, 18 Dec 2024 11:20:58 -0500 Subject: [PATCH] extensions_ui: Don't block scrolling on disabled extension cards (#22189) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This PR fixes an issue where disabled extension cards would block scroll events when the mouse was over them. Instead of using `.occlude`—which captures _all_ mouse events—we use `.block_mouse_down` to just block mouse down events (to prevent clicking the buttons on the disabled card). We also set the cursor style to the default, as it was still switching to the pointer when hovered over top of one of the buttons. Release Notes: - Fixed disabled extensions blocking scroll events in the extensions list. --- crates/extensions_ui/src/components/extension_card.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crates/extensions_ui/src/components/extension_card.rs b/crates/extensions_ui/src/components/extension_card.rs index 2dc472f801a0f28f20b7614955da0168f50978dc..fa3d84b47bfb9aa608f58605ca41d4d95c48bcdd 100644 --- a/crates/extensions_ui/src/components/extension_card.rs +++ b/crates/extensions_ui/src/components/extension_card.rs @@ -48,7 +48,8 @@ impl RenderOnce for ExtensionCard { .absolute() .top_0() .left_0() - .occlude() + .block_mouse_down() + .cursor_default() .size_full() .items_center() .justify_center()