Merge pull request #883 from zed-industries/humanize-underscores

Antonio Scandurra created 3 years ago

Replace underscores with spaces when humanizing action names

Change summary

crates/command_palette/src/command_palette.rs | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

Detailed changes

crates/command_palette/src/command_palette.rs

@@ -269,6 +269,8 @@ fn humanize_action_name(name: &str) -> String {
             } else {
                 result.push(':');
             }
+        } else if char == '_' {
+            result.push(' ');
         } else if char.is_uppercase() {
             if !result.ends_with(' ') {
                 result.push(' ');
@@ -300,13 +302,17 @@ mod tests {
     #[test]
     fn test_humanize_action_name() {
         assert_eq!(
-            &humanize_action_name("editor::GoToDefinition"),
+            humanize_action_name("editor::GoToDefinition"),
             "editor: go to definition"
         );
         assert_eq!(
-            &humanize_action_name("editor::Backspace"),
+            humanize_action_name("editor::Backspace"),
             "editor: backspace"
         );
+        assert_eq!(
+            humanize_action_name("go_to_line::Deploy"),
+            "go to line: deploy"
+        );
     }
 
     #[gpui::test]