From 6a097298b017c5beec002b88345ab3a2f1454197 Mon Sep 17 00:00:00 2001 From: Lukas Wirth Date: Tue, 2 Dec 2025 12:33:00 +0100 Subject: [PATCH] terminal_view: Fix close tab button tooltip showing wrong keybinding on windows (#43981) Closes https://github.com/zed-industries/zed/issues/43882 Release Notes: - Fixed wrong button tooltips being shown for terminal pane on windows --- crates/workspace/src/pane.rs | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/crates/workspace/src/pane.rs b/crates/workspace/src/pane.rs index f149c320a1ee2a17c67781828eacdd412affe663..8182a7dd88ae2577b577ec0505638dcfcff0084c 100644 --- a/crates/workspace/src/pane.rs +++ b/crates/workspace/src/pane.rs @@ -2724,11 +2724,11 @@ impl Pane { .map(|this| { if is_active { let focus_handle = focus_handle.clone(); - this.tooltip(move |_window, cx| { + this.tooltip(move |window, cx| { Tooltip::for_action_in( end_slot_tooltip_text, end_slot_action, - &focus_handle, + &window.focused(cx).unwrap_or_else(|| focus_handle.clone()), cx, ) }) @@ -3031,7 +3031,14 @@ impl Pane { .disabled(!self.can_navigate_backward()) .tooltip({ let focus_handle = focus_handle.clone(); - move |_window, cx| Tooltip::for_action_in("Go Back", &GoBack, &focus_handle, cx) + move |window, cx| { + Tooltip::for_action_in( + "Go Back", + &GoBack, + &window.focused(cx).unwrap_or_else(|| focus_handle.clone()), + cx, + ) + } }); let navigate_forward = IconButton::new("navigate_forward", IconName::ArrowRight) @@ -3047,8 +3054,13 @@ impl Pane { .disabled(!self.can_navigate_forward()) .tooltip({ let focus_handle = focus_handle.clone(); - move |_window, cx| { - Tooltip::for_action_in("Go Forward", &GoForward, &focus_handle, cx) + move |window, cx| { + Tooltip::for_action_in( + "Go Forward", + &GoForward, + &window.focused(cx).unwrap_or_else(|| focus_handle.clone()), + cx, + ) } });