Use alt modifier instead of cmd to add selections

Nathan Sobo created 4 years ago

Change summary

crates/editor/src/element.rs          | 9 +++++----
crates/gpui/src/app.rs                | 2 ++
crates/gpui/src/platform/event.rs     | 4 +++-
crates/gpui/src/platform/mac/event.rs | 2 ++
4 files changed, 12 insertions(+), 5 deletions(-)

Detailed changes

crates/editor/src/element.rs

@@ -55,8 +55,8 @@ impl EditorElement {
     fn mouse_down(
         &self,
         position: Vector2F,
+        alt: bool,
         shift: bool,
-        cmd: bool,
         mut click_count: usize,
         layout: &mut LayoutState,
         paint: &mut PaintState,
@@ -79,7 +79,7 @@ impl EditorElement {
         } else {
             cx.dispatch_action(Select(SelectPhase::Begin {
                 position,
-                add: cmd,
+                add: alt,
                 click_count,
             }));
         }
@@ -861,10 +861,11 @@ impl Element for EditorElement {
             match event {
                 Event::LeftMouseDown {
                     position,
+                    alt,
                     shift,
-                    cmd,
                     click_count,
-                } => self.mouse_down(*position, *shift, *cmd, *click_count, layout, paint, cx),
+                    ..
+                } => self.mouse_down(*position, *alt, *shift, *click_count, layout, paint, cx),
                 Event::LeftMouseUp { position } => self.mouse_up(*position, cx),
                 Event::LeftMouseDragged { position } => {
                     self.mouse_dragged(*position, layout, paint, cx)

crates/gpui/src/app.rs

@@ -3650,6 +3650,8 @@ mod tests {
         presenter.borrow_mut().dispatch_event(
             Event::LeftMouseDown {
                 position: Default::default(),
+                ctrl: false,
+                alt: false,
                 shift: false,
                 cmd: false,
                 click_count: 1,

crates/gpui/src/platform/event.rs

@@ -14,8 +14,10 @@ pub enum Event {
     },
     LeftMouseDown {
         position: Vector2F,
-        cmd: bool,
+        ctrl: bool,
+        alt: bool,
         shift: bool,
+        cmd: bool,
         click_count: usize,
     },
     LeftMouseUp {

crates/gpui/src/platform/mac/event.rs

@@ -92,6 +92,8 @@ impl Event {
                         native_event.locationInWindow().x as f32,
                         window_height - native_event.locationInWindow().y as f32,
                     ),
+                    ctrl: modifiers.contains(NSEventModifierFlags::NSControlKeyMask),
+                    alt: modifiers.contains(NSEventModifierFlags::NSAlternateKeyMask),
                     shift: modifiers.contains(NSEventModifierFlags::NSShiftKeyMask),
                     cmd: modifiers.contains(NSEventModifierFlags::NSCommandKeyMask),
                     click_count: native_event.clickCount() as usize,